You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Matteo Bertozzi (JIRA)" <ji...@apache.org> on 2012/11/06 23:58:13 UTC
[jira] [Created] (HBASE-7108) Don't allow "recovered.edits" as
legal family name
Matteo Bertozzi created HBASE-7108:
--------------------------------------
Summary: Don't allow "recovered.edits" as legal family name
Key: HBASE-7108
URL: https://issues.apache.org/jira/browse/HBASE-7108
Project: HBase
Issue Type: Bug
Components: regionserver
Affects Versions: 0.94.2, 0.92.2, 0.96.0
Reporter: Matteo Bertozzi
Assignee: Matteo Bertozzi
Fix For: 0.96.0
Region directories can contain a folder called "recovered.edits", log splitting related.
But there's nothing that prevent a user to create a family with that name...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7108) Don't allow "recovered.edits" as
legal family name
Posted by "Matteo Bertozzi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matteo Bertozzi updated HBASE-7108:
-----------------------------------
Status: Patch Available (was: Open)
> Don't allow "recovered.edits" as legal family name
> --------------------------------------------------
>
> Key: HBASE-7108
> URL: https://issues.apache.org/jira/browse/HBASE-7108
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.94.2, 0.92.2, 0.96.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Fix For: 0.96.0
>
> Attachments: HBASE-7108-v0.patch
>
>
> Region directories can contain a folder called "recovered.edits", log splitting related.
> But there's nothing that prevent a user to create a family with that name...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7108) Don't allow "recovered.edits" as
legal family name
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492035#comment-13492035 ]
Hadoop QA commented on HBASE-7108:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12552359/HBASE-7108-v0.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 87 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 15 new Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3239//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3239//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3239//console
This message is automatically generated.
> Don't allow "recovered.edits" as legal family name
> --------------------------------------------------
>
> Key: HBASE-7108
> URL: https://issues.apache.org/jira/browse/HBASE-7108
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.92.2, 0.94.2, 0.96.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Fix For: 0.96.0
>
> Attachments: HBASE-7108-v0.patch
>
>
> Region directories can contain a folder called "recovered.edits", log splitting related.
> But there's nothing that prevent a user to create a family with that name...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7108) Don't allow "recovered.edits" as
legal family name
Posted by "Matteo Bertozzi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491932#comment-13491932 ]
Matteo Bertozzi commented on HBASE-7108:
----------------------------------------
yeah good catch, we don't allow the '.' as starting character in the family name.
So, can I just rename "recovered.edits" in ".recovered.edits"?
do we preserve fs layout compatibility in some way?
> Don't allow "recovered.edits" as legal family name
> --------------------------------------------------
>
> Key: HBASE-7108
> URL: https://issues.apache.org/jira/browse/HBASE-7108
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.92.2, 0.94.2, 0.96.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Fix For: 0.96.0
>
> Attachments: HBASE-7108-v0.patch
>
>
> Region directories can contain a folder called "recovered.edits", log splitting related.
> But there's nothing that prevent a user to create a family with that name...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7108) Don't allow "recovered.edits" as
legal family name
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491924#comment-13491924 ]
Todd Lipcon commented on HBASE-7108:
------------------------------------
Instead of disallowing it, could we change recovered.edits to be something starting with a '.'? I think we already have some requirement that CFs not start with '.', right? (if not, is there any other prefix which we've already disallowed for users?)
> Don't allow "recovered.edits" as legal family name
> --------------------------------------------------
>
> Key: HBASE-7108
> URL: https://issues.apache.org/jira/browse/HBASE-7108
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.92.2, 0.94.2, 0.96.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Fix For: 0.96.0
>
> Attachments: HBASE-7108-v0.patch
>
>
> Region directories can contain a folder called "recovered.edits", log splitting related.
> But there's nothing that prevent a user to create a family with that name...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7108) Don't use legal family name for
system folder at region level
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499948#comment-13499948 ]
stack commented on HBASE-7108:
------------------------------
Todd's suggestion sounds good to me.
> Don't use legal family name for system folder at region level
> -------------------------------------------------------------
>
> Key: HBASE-7108
> URL: https://issues.apache.org/jira/browse/HBASE-7108
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.92.2, 0.94.2, 0.96.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Fix For: 0.96.0
>
> Attachments: HBASE-7108-v0.patch
>
>
> CHANGED, was: Don't allow "recovered.edits" as legal family name
> Region directories can contain folders called "recovered.edits", log splitting related.
> But there's nothing that prevent a user to create a family with that name...
> HLog.RECOVERED_EDITS_DIR = "recovered.edits";
> HRegion.MERGEDIR = "merges"; // fixed with HBASE-6158
> SplitTransaction.SPLITDIR = "splits"; // fixed with HBASE-6158
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7108) Don't use legal family name for
system folder at region level
Posted by "Matteo Bertozzi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matteo Bertozzi updated HBASE-7108:
-----------------------------------
Description:
CHANGED, was: Don't allow "recovered.edits" as legal family name
Region directories can contain folders called "recovered.edits", log splitting related.
But there's nothing that prevent a user to create a family with that name...
HLog.RECOVERED_EDITS_DIR = "recovered.edits";
HRegion.MERGEDIR = "merges"; // fixed with HBASE-6158
SplitTransaction.SPLITDIR = "splits"; // fixed with HBASE-6158
was:
Region directories can contain a folder called "recovered.edits", log splitting related.
But there's nothing that prevent a user to create a family with that name...
Summary: Don't use legal family name for system folder at region level (was: Don't allow "recovered.edits" as legal family name)
> Don't use legal family name for system folder at region level
> -------------------------------------------------------------
>
> Key: HBASE-7108
> URL: https://issues.apache.org/jira/browse/HBASE-7108
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.92.2, 0.94.2, 0.96.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Fix For: 0.96.0
>
> Attachments: HBASE-7108-v0.patch
>
>
> CHANGED, was: Don't allow "recovered.edits" as legal family name
> Region directories can contain folders called "recovered.edits", log splitting related.
> But there's nothing that prevent a user to create a family with that name...
> HLog.RECOVERED_EDITS_DIR = "recovered.edits";
> HRegion.MERGEDIR = "merges"; // fixed with HBASE-6158
> SplitTransaction.SPLITDIR = "splits"; // fixed with HBASE-6158
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7108) Don't allow "recovered.edits" as
legal family name
Posted by "Matteo Bertozzi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matteo Bertozzi updated HBASE-7108:
-----------------------------------
Attachment: HBASE-7108-v0.patch
added patch to mark "recovered.edits" as Illegal family name
> Don't allow "recovered.edits" as legal family name
> --------------------------------------------------
>
> Key: HBASE-7108
> URL: https://issues.apache.org/jira/browse/HBASE-7108
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.92.2, 0.94.2, 0.96.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Fix For: 0.96.0
>
> Attachments: HBASE-7108-v0.patch
>
>
> Region directories can contain a folder called "recovered.edits", log splitting related.
> But there's nothing that prevent a user to create a family with that name...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7108) Don't allow "recovered.edits" as
legal family name
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491991#comment-13491991 ]
Todd Lipcon commented on HBASE-7108:
------------------------------------
For compatibility, one option would be:
- in 0.94: change code to recognize both "recovered.edits" and ".recovered.edits" at region-open time
- in 0.96: change code to write to ".recovered.edits" and recognize both
Then, so long as someone is upgrading from the most recent 0.94 to 0.96, they'd be fine. An upgrade from an older 0.94 or 0.92 to 0.96 would potentially have an issue if there were a failure in the middle of a rolling upgrade.
Would that be acceptible?
> Don't allow "recovered.edits" as legal family name
> --------------------------------------------------
>
> Key: HBASE-7108
> URL: https://issues.apache.org/jira/browse/HBASE-7108
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.92.2, 0.94.2, 0.96.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Fix For: 0.96.0
>
> Attachments: HBASE-7108-v0.patch
>
>
> Region directories can contain a folder called "recovered.edits", log splitting related.
> But there's nothing that prevent a user to create a family with that name...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira