You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Alexander Rukletsov <al...@mesosphere.io> on 2015/02/02 19:29:30 UTC

Re: Review Request 30442: Update mesos for query string encode/decode

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30442/#review70594
-----------------------------------------------------------

Ship it!


One minor nit, otherwise LGTM.


src/tests/repair_tests.cpp
<https://reviews.apache.org/r/30442/#comment115801>

    4 spaces indent here.


- Alexander Rukletsov


On Jan. 30, 2015, 3:10 a.m., Cody Maloney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30442/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2015, 3:10 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update mesos for query string encode/decode
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 3981b18cb82d3b8bd974b80d27f14c304898a43c 
>   src/tests/repair_tests.cpp 5235058263d661dfa6445b0b443af6290e2ea016 
> 
> Diff: https://reviews.apache.org/r/30442/diff/
> 
> 
> Testing
> -------
> 
> make distcheck on Ubuntu 14.04
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>