You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/16 21:40:14 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #5985: [Issue 5935] Support multi pulsar clusters to use the same bk cluster

sijie commented on a change in pull request #5985: [Issue 5935] Support multi pulsar clusters to use the same bk cluster
URL: https://github.com/apache/pulsar/pull/5985#discussion_r409864585
 
 

 ##########
 File path: pulsar-common/src/main/java/org/apache/pulsar/common/conf/InternalConfigurationData.java
 ##########
 @@ -28,19 +28,19 @@
 
     private String zookeeperServers;
     private String configurationStoreServers;
-    private String ledgersRootPath;
 
 Review comment:
   for backward compatibility, you shouldn't change the field directly. 
   
   You can add a new field `bookkeeperMetadataServiceUri` and deprecate the old field `ledgersRootPath `.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services