[GitHub] [superset] zhaoyongjie commented on a diff in pull request #20784: fix: core coverage and add a coverage step in workflow

[GitBox <gi...@apache.org>]

zhaoyongjie commented on code in PR #20784:
URL: https://github.com/apache/superset/pull/20784#discussion_r925435641


##########
superset-frontend/packages/superset-ui-core/src/query/types/Datasource.ts:
##########
@@ -53,7 +53,4 @@ export const DEFAULT_METRICS: Metric[] = [
   },
 ];
 
-export const isValidDatasourceType = (datasource: DatasourceType) =>

Review Comment:
   This function is unused, a more readable expression is `'Table' in DatasourceType`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org