[GitHub] [flink] kl0u commented on a change in pull request #14157: [FLINK-19969] CLI print run-application help msg

[GitBox <gi...@apache.org>]

kl0u commented on a change in pull request #14157:
URL: https://github.com/apache/flink/pull/14157#discussion_r528578010



##########
File path: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
##########
@@ -371,6 +372,18 @@ public static void printHelpForRun(Collection<CustomCommandLine> customCommandLi
 		System.out.println();
 	}
 
+	public static void printHelpForRunApplication() {
+		HelpFormatter formatter = new HelpFormatter();
+		formatter.setLeftPadding(5);
+		formatter.setWidth(80);
+
+		System.out.println("\nAction \"run-application\" runs an application in Application Mode.");
+		System.out.println("\n  Syntax: run-application -t [kubernetes-application, yarn-application] [OPTIONS] <jar-file> <arguments>");

Review comment:
       For the `-t` I put them here because these are the only valid options for `run-application`. The rest are not compatible with the `run-application` command.
   
   The reason for hardcoding the `foo-application` is a combination of what you said, and also the package structure of the project that makes it impossible to find all available executors without service discovery.
   
   Now for the separation, you mean that we should not have a separate command (like `run-application`) or something else?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org