You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "zephyring (via GitHub)" <gi...@apache.org> on 2023/08/28 19:36:48 UTC
[GitHub] [superset] zephyring opened a new pull request, #25104: chore: adding ALERT_REPORTS_SHOULD_LOG_STATS to config to enable/disa…
zephyring opened a new pull request, #25104:
URL: https://github.com/apache/superset/pull/25104
…ble statlogger for alert report tasks
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #25104: chore: adding ALERT_REPORTS_SHOULD_LOG_STATS to config to enable/disa…
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #25104:
URL: https://github.com/apache/superset/pull/25104#issuecomment-1696360267
@zephyring I assume this is a reaction to this recent PR: #25080. Did this cause issues in your env? I assumed the change would be very low impact, as we have a fair amount of StatsD metrics throughout the code base. Just curious so I understand what adverse implications this may have had..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zephyring commented on pull request #25104: chore: adding ALERT_REPORTS_SHOULD_LOG_STATS to config to enable/disa…
Posted by "zephyring (via GitHub)" <gi...@apache.org>.
zephyring commented on PR #25104:
URL: https://github.com/apache/superset/pull/25104#issuecomment-1696396832
> @zephyring I assume this is a reaction to this recent PR: #25080. Did this cause issues in your env? I assumed the change would be very low impact, as we have a fair amount of StatsD metrics throughout the code base. Just curious so I understand what adverse implications this may have had..
1. In preset we have lots of superset instances and each instance will start emitting a stats log every minutes. This is gonna be too noisy for us.
2. I think providing a config here will make it explicit that we're doing this stats log in report schedule so if other parties can also leverage if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #25104: chore: adding ALERT_REPORTS_SHOULD_LOG_STATS to config to enable/disa…
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #25104:
URL: https://github.com/apache/superset/pull/25104#issuecomment-1696615136
@villebro had a good suggestion to create a denylist for logs/statsd, and in that way we can have one config to block any future logs that any particular admin may want to disable. We'll go in that direction for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho closed pull request #25104: chore: adding ALERT_REPORTS_SHOULD_LOG_STATS to config to enable/disa…
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho closed pull request #25104: chore: adding ALERT_REPORTS_SHOULD_LOG_STATS to config to enable/disa…
URL: https://github.com/apache/superset/pull/25104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org