You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ode.apache.org by "Gary Brown (JIRA)" <ji...@apache.org> on 2011/02/25 13:21:38 UTC
[jira] Created: (ODE-915) Add inline variable initialization
support - backport of patch from ODE2 codebase
Add inline variable initialization support - backport of patch from ODE2 codebase
---------------------------------------------------------------------------------
Key: ODE-915
URL: https://issues.apache.org/jira/browse/ODE-915
Project: ODE
Issue Type: Improvement
Reporter: Gary Brown
Fix For: 1.4
Attachments: ODE-236-for-1.4.patch
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (ODE-915) Add inline variable initialization
support - backport of patch from ODE2 codebase
Posted by Gary Brown <ga...@pi4tech.com>.
Good point. Possibly one solution would be to retain the HashMap and raise a
separate issue regarding use of the LinkedHashMap. It would only impact
where one variable initialisation is based on another?
Regards
Gary
On Fri, Feb 25, 2011 at 12:29 PM, Tammo van Lessen (JIRA)
<ji...@apache.org>wrote:
>
> [
> https://issues.apache.org/jira/browse/ODE-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999335#comment-12999335]
>
> Tammo van Lessen commented on ODE-915:
> --------------------------------------
>
> Hi Gary, thanks for the patch. I'm afraid before we can apply the patch, we
> need to address the OModel evolution issue. The patch changes a field from
> HashMap to LinkedHashMap, I'm not sure if these guys are binary
> compatible...
>
> > Add inline variable initialization support - backport of patch from ODE2
> codebase
> >
> ---------------------------------------------------------------------------------
> >
> > Key: ODE-915
> > URL: https://issues.apache.org/jira/browse/ODE-915
> > Project: ODE
> > Issue Type: Improvement
> > Reporter: Gary Brown
> > Fix For: 1.4
> >
> > Attachments: ODE-236-for-1.4.patch
> >
> >
>
>
> --
> This message is automatically generated by JIRA.
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
[jira] Commented: (ODE-915) Add inline variable initialization
support - backport of patch from ODE2 codebase
Posted by "Gary Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999351#comment-12999351 ]
Gary Brown commented on ODE-915:
--------------------------------
Good point. Possibly one solution would be to retain the HashMap and raise a
separate issue regarding use of the LinkedHashMap. It would only impact
where one variable initialisation is based on another?
Regards
Gary
On Fri, Feb 25, 2011 at 12:29 PM, Tammo van Lessen (JIRA)
> Add inline variable initialization support - backport of patch from ODE2 codebase
> ---------------------------------------------------------------------------------
>
> Key: ODE-915
> URL: https://issues.apache.org/jira/browse/ODE-915
> Project: ODE
> Issue Type: Improvement
> Reporter: Gary Brown
> Fix For: 1.4
>
> Attachments: ODE-236-for-1.4.patch
>
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ODE-915) Add inline variable initialization
support - backport of patch from ODE2 codebase
Posted by "Gary Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Brown updated ODE-915:
---------------------------
Attachment: ODE-915.patch
An alternative version with separate arraylist to maintain ordering.
Not sure how long it will take to discuss and then implement an evolvable solution - so this would atleast enable the functionality to be supported in the meantime.
> Add inline variable initialization support - backport of patch from ODE2 codebase
> ---------------------------------------------------------------------------------
>
> Key: ODE-915
> URL: https://issues.apache.org/jira/browse/ODE-915
> Project: ODE
> Issue Type: Improvement
> Reporter: Gary Brown
> Fix For: 1.4
>
> Attachments: ODE-236-for-1.4.patch, ODE-915.patch
>
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (ODE-915) Add inline variable initialization
support - backport of patch from ODE2 codebase
Posted by "Jeff Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeff Yu reassigned ODE-915:
---------------------------
Assignee: Jeff Yu
> Add inline variable initialization support - backport of patch from ODE2 codebase
> ---------------------------------------------------------------------------------
>
> Key: ODE-915
> URL: https://issues.apache.org/jira/browse/ODE-915
> Project: ODE
> Issue Type: Improvement
> Reporter: Gary Brown
> Assignee: Jeff Yu
> Fix For: 1.4
>
> Attachments: ODE-236-for-1.4.patch, ODE-915.patch
>
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ODE-915) Add inline variable initialization
support - backport of patch from ODE2 codebase
Posted by "Gary Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Brown updated ODE-915:
---------------------------
Attachment: ODE-915-2.patch
Slightly modifed patch to remove the backward compatibility issues found in the previous patch.
> Add inline variable initialization support - backport of patch from ODE2 codebase
> ---------------------------------------------------------------------------------
>
> Key: ODE-915
> URL: https://issues.apache.org/jira/browse/ODE-915
> Project: ODE
> Issue Type: Improvement
> Reporter: Gary Brown
> Assignee: Jeff Yu
> Fix For: 1.4
>
> Attachments: ODE-236-for-1.4.patch, ODE-915-2.patch, ODE-915.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ODE-915) Add inline variable initialization
support - backport of patch from ODE2 codebase
Posted by "Jeff Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000267#comment-13000267 ]
Jeff Yu commented on ODE-915:
-----------------------------
I agreed with Gary, we can raise this as a separate issue, and then apply this patch first.
Also as we planned, the 1.4 release should be quite different from 1.3.x release, one reason for this would be to ask users migrate from dao-hibernate to the jpa-hibernate.
What do you think, Tammo?
> Add inline variable initialization support - backport of patch from ODE2 codebase
> ---------------------------------------------------------------------------------
>
> Key: ODE-915
> URL: https://issues.apache.org/jira/browse/ODE-915
> Project: ODE
> Issue Type: Improvement
> Reporter: Gary Brown
> Assignee: Jeff Yu
> Fix For: 1.4
>
> Attachments: ODE-236-for-1.4.patch, ODE-915.patch
>
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ODE-915) Add inline variable initialization
support - backport of patch from ODE2 codebase
Posted by "Tammo van Lessen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999335#comment-12999335 ]
Tammo van Lessen commented on ODE-915:
--------------------------------------
Hi Gary, thanks for the patch. I'm afraid before we can apply the patch, we need to address the OModel evolution issue. The patch changes a field from HashMap to LinkedHashMap, I'm not sure if these guys are binary compatible...
> Add inline variable initialization support - backport of patch from ODE2 codebase
> ---------------------------------------------------------------------------------
>
> Key: ODE-915
> URL: https://issues.apache.org/jira/browse/ODE-915
> Project: ODE
> Issue Type: Improvement
> Reporter: Gary Brown
> Fix For: 1.4
>
> Attachments: ODE-236-for-1.4.patch
>
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ODE-915) Add inline variable initialization
support - backport of patch from ODE2 codebase
Posted by "Jeff Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009097#comment-13009097 ]
Jeff Yu commented on ODE-915:
-----------------------------
As I said in the email of ode-dev maillist, I've verified the Gary's ODE-915-2.patch with current ode-trunk code, it doesn't have the binary compatibility issues.
what I did is between ODE-trunk and ODE-trunk + ODE-915-2.patch.
However, I found that we had binary compatibility issue between the ODE-1.3.5 and ODE-trunk.
> Add inline variable initialization support - backport of patch from ODE2 codebase
> ---------------------------------------------------------------------------------
>
> Key: ODE-915
> URL: https://issues.apache.org/jira/browse/ODE-915
> Project: ODE
> Issue Type: Improvement
> Reporter: Gary Brown
> Assignee: Jeff Yu
> Fix For: 1.4
>
> Attachments: ODE-236-for-1.4.patch, ODE-915-2.patch, ODE-915.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira