You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/04/07 15:47:30 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #5918: Use generics instead of borrow for zero-cost
alamb opened a new pull request, #5918:
URL: https://github.com/apache/arrow-datafusion/pull/5918
This is based on @ozankabak 's PR https://github.com/alamb/arrow-datafusion/pull/11
I tried to pull the commits from that branch to make this work on `main`
It currently failing to compile with
```
error[E0277]: the trait bound `PhysicalSortExpr: From<&PhysicalSortRequirement>` is not satisfied
--> datafusion/core/src/physical_optimizer/sort_pushdown.rs:131:17
|
131 | PhysicalSortRequirement::to_sort_exprs(parent_required.ok_or_else(err)?);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `From<&PhysicalSortRequirement>` is not implemented for `PhysicalSortExpr`
|
= help: the trait `From<PhysicalSortRequirement>` is implemented for `PhysicalSortExpr`
note: required by a bound in `PhysicalSortRequirement::to_sort_exprs`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed pull request #5918: Use generics instead of borrow for zero-cost
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed pull request #5918: Use generics instead of borrow for zero-cost
URL: https://github.com/apache/arrow-datafusion/pull/5918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5918: Use generics instead of borrow for zero-cost
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5918:
URL: https://github.com/apache/arrow-datafusion/pull/5918#issuecomment-1527674661
Doesn't seem like we have made progress here, closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ozankabak commented on pull request #5918: Use generics instead of borrow for zero-cost
Posted by "ozankabak (via GitHub)" <gi...@apache.org>.
ozankabak commented on PR #5918:
URL: https://github.com/apache/arrow-datafusion/pull/5918#issuecomment-1500409843
It needs:
```rust
impl From<&PhysicalSortRequirement> for PhysicalSortExpr {
fn from(value: &PhysicalSortRequirement) -> Self {
value.clone().into_sort_expr()
}
}
```
and
```rust
impl From<&PhysicalSortExpr> for PhysicalSortRequirement {
fn from(value: &PhysicalSortExpr) -> Self {
PhysicalSortRequirement::from(value.clone())
}
}
```
so that `to_sort_exprs` and `from_sort_exprs` can work with both reference and owned arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org