You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "EnxDev (via GitHub)" <gi...@apache.org> on 2026/05/26 14:19:50 UTC
[PR] feat(extensions): define the superset.chatbot contribution point [superset]
EnxDev opened a new pull request, #40439:
URL: https://github.com/apache/superset/pull/40439
### SUMMARY
Adds the `superset.chatbot` contribution point to the `@apache-superset/core` declaration package and the host-side `ViewContributions` manifest.
**What this introduces:**
- `AppLocation = 'chatbot'` in `ViewContributions` — a fixed bottom-right slot that persists across all routes
- `ChatbotView` type exported from `@apache-superset/core` — the shape extensions register to provide a chatbot bubble
- `CHATBOT_LOCATION` constant in `src/views/contributions` — the host-side identifier used to look up registered chatbot views
- `ChatbotMount` component — renders the active chatbot in a fixed overlay; resolves reactively as extensions register
This is part of a [stacked PR series](https://github.com/apache/superset/pull/40433) implementing the `superset.chatbot` SIP.
**Stack:**
1. **This PR** — contribution point definition
2. [Frontend API entry point](https://github.com/apache/superset/compare/enxdev/feat/chatbot-contribution-point...enxdev/feat/chatbot-frontend-api)
3. Eager loading at startup
4. Admin configuration UI
5. Backend settings persistence & permissions
6. Context sharing namespaces
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — no visible UI change in this commit (mount point renders nothing until an extension registers).
### TESTING INSTRUCTIONS
1. `cd superset-frontend && npm run build`
2. Verify `@apache-superset/core/lib/contributions` exports `ChatbotView` and `AppLocation`
3. Verify `src/views/contributions.ts` exports `CHATBOT_LOCATION = 'chatbot'`
4. No runtime errors on page load
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(extensions): define the superset.chatbot contribution point [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #40439:
URL: https://github.com/apache/superset/pull/40439#issuecomment-4544995747
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | c5e0696ab9e7116c40518e01e2042bc8cc6997a6 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a15ac051b8460000850509c |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-40439--superset-docs-preview.netlify.app](https://deploy-preview-40439--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcvBCYAwDEDRXXJWrGCLuoFjpGnFgialRFHE3e0__ct7IRc5ssIM0IAvyLTVj3yHeHVrRO1oQ_WiLQlrSf7UJNxmSaxVhJh3eZZQjcPeIhnb-3FwpjZaY81E8P0) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-40439--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(extensions): define the superset.chatbot contribution point [superset]
Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev commented on PR #40439:
URL: https://github.com/apache/superset/pull/40439#issuecomment-4573067609
> So, i think the stacked pr's are a bit off now. All the pr's for the feature are opened against the feature branch, not on top of each other which means the last pr on the list have all the changes already. This is an antipattern in which you will have conflicts after each pr is merged and we can't parallelize the reviews. We should make each pr's base branch the previous pr instead so we avoid these.
Something went wrong with the base branch, but I’ve updated it, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(extensions): define the superset.chatbot contribution point [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40439:
URL: https://github.com/apache/superset/pull/40439#issuecomment-4545272118
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/40439?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 64.18%. Comparing base ([`b0d2619`](https://app.codecov.io/gh/apache/superset/commit/b0d26196fc50340cfca4ee27373bf5b81f95e8b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c77c9b2`](https://app.codecov.io/gh/apache/superset/commit/c77c9b29f96a21518f25629e1710fecd981a053e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/40439?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset-frontend/src/views/contributions.ts](https://app.codecov.io/gh/apache/superset/pull/40439?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fviews%2Fcontributions.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NvbnRyaWJ1dGlvbnMudHM=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/40439?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## enxdev/chat-prototype #40439 +/- ##
=========================================================
- Coverage 64.18% 64.18% -0.01%
=========================================================
Files 2592 2593 +1
Lines 139036 139038 +2
Branches 32282 32282
=========================================================
Hits 89244 89244
- Misses 48260 48262 +2
Partials 1532 1532
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/40439/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/40439/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.28% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/40439?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(extensions): define the superset.chatbot contribution point [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40439:
URL: https://github.com/apache/superset/pull/40439#issuecomment-4544964154
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(extensions): define the superset.chatbot contribution point [superset]
Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev merged PR #40439:
URL: https://github.com/apache/superset/pull/40439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(extensions): define the superset.chatbot contribution point [superset]
Posted by "msyavuz (via GitHub)" <gi...@apache.org>.
msyavuz commented on PR #40439:
URL: https://github.com/apache/superset/pull/40439#issuecomment-4564490733
So, i think the stacked pr's are a bit off now. All the pr's for the feature are opened against the feature branch, not on top of each other which means the last pr on the list have all the changes already. This is an antipattern in which you will have conflicts after each pr is merged and we can't parallelize the reviews. We should make each pr's base branch the previous pr instead so we avoid these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org