You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Nixon Rodrigues <ni...@freestoneinfotech.com> on 2017/01/03 14:23:22 UTC
Review Request 55138: ATLAS-1424 - Avoid stack-trace in REST API error
response
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55138/
-----------------------------------------------------------
Review request for atlas, keval bhatt, Madhan Neethiraj, and Vimal Sharma.
Bugs: ATLAS-1424
https://issues.apache.org/jira/browse/ATLAS-1424
Repository: atlas
Description
-------
This patch provides fix to avoid stack-trace in REST API error response, by removing stacktrace attribute from json response.
Diffs
-----
webapp/src/main/java/org/apache/atlas/web/util/Servlets.java b4f0839
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 23203ec
Diff: https://reviews.apache.org/r/55138/diff/
Testing
-------
Execute test cases using mvn clean install
Tested json response for discovery, types, entity type of api's in normal & exceptional conditions.
Thanks,
Nixon Rodrigues
Re: Review Request 55138: ATLAS-1424 - Avoid stack-trace in REST API
error response
Posted by Madhan Neethiraj <ma...@apache.org>.
> On Jan. 3, 2017, 4:08 p.m., David Radley wrote:
> > Hi, Can you confirm that after fix, the stack trace for this exception will be logged - even if it is not sent back in the REST response.
The fix only removes the stack trace from HTTP response. I confirmed that the error log generated continues to include the stack trace.
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55138/#review160391
-----------------------------------------------------------
On Jan. 3, 2017, 2:23 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55138/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 2:23 p.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Vimal Sharma.
>
>
> Bugs: ATLAS-1424
> https://issues.apache.org/jira/browse/ATLAS-1424
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch provides fix to avoid stack-trace in REST API error response, by removing stacktrace attribute from json response.
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/util/Servlets.java b4f0839
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 23203ec
>
> Diff: https://reviews.apache.org/r/55138/diff/
>
>
> Testing
> -------
>
> Execute test cases using mvn clean install
>
> Tested json response for discovery, types, entity type of api's in normal & exceptional conditions.
>
>
> Thanks,
>
> Nixon Rodrigues
>
>
Re: Review Request 55138: ATLAS-1424 - Avoid stack-trace in REST API
error response
Posted by David Radley <da...@uk.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55138/#review160391
-----------------------------------------------------------
Hi, Can you confirm that after fix, the stack trace for this exception will be logged - even if it is not sent back in the REST response.
- David Radley
On Jan. 3, 2017, 2:23 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55138/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 2:23 p.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Vimal Sharma.
>
>
> Bugs: ATLAS-1424
> https://issues.apache.org/jira/browse/ATLAS-1424
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch provides fix to avoid stack-trace in REST API error response, by removing stacktrace attribute from json response.
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/util/Servlets.java b4f0839
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 23203ec
>
> Diff: https://reviews.apache.org/r/55138/diff/
>
>
> Testing
> -------
>
> Execute test cases using mvn clean install
>
> Tested json response for discovery, types, entity type of api's in normal & exceptional conditions.
>
>
> Thanks,
>
> Nixon Rodrigues
>
>
Re: Review Request 55138: ATLAS-1424 - Avoid stack-trace in REST API
error response
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55138/#review160394
-----------------------------------------------------------
Fix it, then Ship it!
webapp/src/main/java/org/apache/atlas/web/util/Servlets.java (line 140)
<https://reviews.apache.org/r/55138/#comment231525>
printStackTrace() method is no more referenced; hence can be removed. I will remove it before committing the patch.
- Madhan Neethiraj
On Jan. 3, 2017, 2:23 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55138/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 2:23 p.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Vimal Sharma.
>
>
> Bugs: ATLAS-1424
> https://issues.apache.org/jira/browse/ATLAS-1424
>
>
> Repository: atlas
>
>
> Description
> -------
>
> This patch provides fix to avoid stack-trace in REST API error response, by removing stacktrace attribute from json response.
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/util/Servlets.java b4f0839
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 23203ec
>
> Diff: https://reviews.apache.org/r/55138/diff/
>
>
> Testing
> -------
>
> Execute test cases using mvn clean install
>
> Tested json response for discovery, types, entity type of api's in normal & exceptional conditions.
>
>
> Thanks,
>
> Nixon Rodrigues
>
>