You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Robert Liguori (JIRA)" <ji...@apache.org> on 2011/07/24 06:37:09 UTC

[jira] [Created] (CXF-3683) CXF Examples (multiple), Warnings: The method toURL() from the type File is deprecated

CXF Examples (multiple), Warnings: The method toURL() from the type File is deprecated
--------------------------------------------------------------------------------------

                 Key: CXF-3683
                 URL: https://issues.apache.org/jira/browse/CXF-3683
             Project: CXF
          Issue Type: Improvement
          Components: Samples
    Affects Versions: 2.4.1
         Environment: Mulitple CXF Sample Projects
            Reporter: Robert Liguori
            Priority: Trivial


This is not necessarily an issue, though trying to achieve the goal of removing all warnings from the sample projects, this would be a nice-to-have.

"The toURL() method of File does not properly escape characters that aren't valid in a URL." -- http://www.jguru.com/faq/view.jsp?EID=1280051

As such, the following sample project display warning due to lines constructed as such:

   wsdlURL = wsdlFile.toURL();

The recommendation is to update the source in the listed projects as such (as appropriate):

   wsdlURL = wsdlFile.toURI().toURL(); 

Affected sample projects:

callback
configuration_interceptor
in_jvm_transport
jax_rs_basic_https
jaxws_async
jaxws_dispatch_provider
jaxws_handlers
js_browser_client_simple
js_client
mtom
soap_header
ws_addressing
ws_rm
wsdl_first
wsdl_first_dynamic_client
wsdl_first_https
wsdl_first_pure_xml
wsdl_first_rpclit
wsdl_first_soap12
wsdl_first_xml_wrapped
wsdl_first_xmlbeans
wssec_ut_policy

Note: I did not supply diffs, as it's far easier for someone with commit access to pass through the files and make the simple updates.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-3683) CXF Examples (multiple), Warnings: The method toURL() from the type File is deprecated

Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070114#comment-13070114 ] 

Glen Mazza commented on CXF-3683:
---------------------------------

Hi Robert, what software is declaring this to be a "warning"?  It's best to provide a source declaring it as such in order to judge its validity.  Just because this IDE or that IDE is coded to moan about a programmatic choice doesn't necessarily mean we need to change the code (as they moan about a *lot*, not always relevant for the situation we're in.)

I'm not sure we're to be escaping WSDL file URLs; further, if the concern mentioned that would require the escaping will actually ever occur within the code.

> CXF Examples (multiple), Warnings: The method toURL() from the type File is deprecated
> --------------------------------------------------------------------------------------
>
>                 Key: CXF-3683
>                 URL: https://issues.apache.org/jira/browse/CXF-3683
>             Project: CXF
>          Issue Type: Improvement
>          Components: Samples
>    Affects Versions: 2.4.1
>         Environment: Mulitple CXF Sample Projects
>            Reporter: Robert Liguori
>            Priority: Trivial
>
> This is not necessarily an issue, though trying to achieve the goal of removing all warnings from the sample projects, this would be a nice-to-have.
> "The toURL() method of File does not properly escape characters that aren't valid in a URL." -- http://www.jguru.com/faq/view.jsp?EID=1280051
> As such, the following sample project display warning due to lines constructed as such:
>    wsdlURL = wsdlFile.toURL();
> The recommendation is to update the source in the listed projects as such (as appropriate):
>    wsdlURL = wsdlFile.toURI().toURL(); 
> Affected sample projects:
> callback
> configuration_interceptor
> in_jvm_transport
> jax_rs_basic_https
> jaxws_async
> jaxws_dispatch_provider
> jaxws_handlers
> js_browser_client_simple
> js_client
> mtom
> soap_header
> ws_addressing
> ws_rm
> wsdl_first
> wsdl_first_dynamic_client
> wsdl_first_https
> wsdl_first_pure_xml
> wsdl_first_rpclit
> wsdl_first_soap12
> wsdl_first_xml_wrapped
> wsdl_first_xmlbeans
> wssec_ut_policy
> Note: I did not supply diffs, as it's far easier for someone with commit access to pass through the files and make the simple updates.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-3683) CXF Examples (multiple), Warnings: The method toURL() from the type File is deprecated

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070597#comment-13070597 ] 

Daniel Kulp commented on CXF-3683:
----------------------------------


Actually, I disagree with Glen here.   Fixing compiler warnings in the examples is valuable as long as it doesn't introduce new compiler warnings or issues with the "default" compilers.    We do go out of the way (or at least I do) to make sure the CXF source  is completely warning free with Eclipse, it would be good to do the same for the examples.




> CXF Examples (multiple), Warnings: The method toURL() from the type File is deprecated
> --------------------------------------------------------------------------------------
>
>                 Key: CXF-3683
>                 URL: https://issues.apache.org/jira/browse/CXF-3683
>             Project: CXF
>          Issue Type: Improvement
>          Components: Samples
>    Affects Versions: 2.4.1
>         Environment: Mulitple CXF Sample Projects
> Eclipse IDE SDK 3.7.0 
>            Reporter: Robert Liguori
>            Priority: Trivial
>
> "The toURL() method of File does not properly escape characters that aren't valid in a URL." -- http://www.jguru.com/faq/view.jsp?EID=1280051
> As such, the following sample project display warning due to lines constructed as such:
>    wsdlURL = wsdlFile.toURL();
> The recommendation is to update the source in the listed projects as such (as appropriate):
>    wsdlURL = wsdlFile.toURI().toURL(); 
> Affected sample projects:
> callback
> configuration_interceptor
> in_jvm_transport
> jax_rs_basic_https
> jaxws_async
> jaxws_dispatch_provider
> jaxws_handlers
> js_browser_client_simple
> js_client
> mtom
> soap_header
> ws_addressing
> ws_rm
> wsdl_first
> wsdl_first_dynamic_client
> wsdl_first_https
> wsdl_first_pure_xml
> wsdl_first_rpclit
> wsdl_first_soap12
> wsdl_first_xml_wrapped
> wsdl_first_xmlbeans
> wssec_ut_policy
> Note: I did not supply diffs, as it's far easier for someone with commit access to pass through the files and make the simple updates.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CXF-3683) CXF Examples (multiple), Warnings: The method toURL() from the type File is deprecated

Posted by "Robert Liguori (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Liguori updated CXF-3683:
--------------------------------

    Description: 
"The toURL() method of File does not properly escape characters that aren't valid in a URL." -- http://www.jguru.com/faq/view.jsp?EID=1280051

As such, the following sample project display warning due to lines constructed as such:

   wsdlURL = wsdlFile.toURL();

The recommendation is to update the source in the listed projects as such (as appropriate):

   wsdlURL = wsdlFile.toURI().toURL(); 

Affected sample projects:

callback
configuration_interceptor
in_jvm_transport
jax_rs_basic_https
jaxws_async
jaxws_dispatch_provider
jaxws_handlers
js_browser_client_simple
js_client
mtom
soap_header
ws_addressing
ws_rm
wsdl_first
wsdl_first_dynamic_client
wsdl_first_https
wsdl_first_pure_xml
wsdl_first_rpclit
wsdl_first_soap12
wsdl_first_xml_wrapped
wsdl_first_xmlbeans
wssec_ut_policy

Note: I did not supply diffs, as it's far easier for someone with commit access to pass through the files and make the simple updates.

  was:
This is not necessarily an issue, though trying to achieve the goal of removing all warnings from the sample projects, this would be a nice-to-have.

"The toURL() method of File does not properly escape characters that aren't valid in a URL." -- http://www.jguru.com/faq/view.jsp?EID=1280051

As such, the following sample project display warning due to lines constructed as such:

   wsdlURL = wsdlFile.toURL();

The recommendation is to update the source in the listed projects as such (as appropriate):

   wsdlURL = wsdlFile.toURI().toURL(); 

Affected sample projects:

callback
configuration_interceptor
in_jvm_transport
jax_rs_basic_https
jaxws_async
jaxws_dispatch_provider
jaxws_handlers
js_browser_client_simple
js_client
mtom
soap_header
ws_addressing
ws_rm
wsdl_first
wsdl_first_dynamic_client
wsdl_first_https
wsdl_first_pure_xml
wsdl_first_rpclit
wsdl_first_soap12
wsdl_first_xml_wrapped
wsdl_first_xmlbeans
wssec_ut_policy

Note: I did not supply diffs, as it's far easier for someone with commit access to pass through the files and make the simple updates.


> CXF Examples (multiple), Warnings: The method toURL() from the type File is deprecated
> --------------------------------------------------------------------------------------
>
>                 Key: CXF-3683
>                 URL: https://issues.apache.org/jira/browse/CXF-3683
>             Project: CXF
>          Issue Type: Improvement
>          Components: Samples
>    Affects Versions: 2.4.1
>         Environment: Mulitple CXF Sample Projects
> Eclipse IDE SDK 3.7.0 
>            Reporter: Robert Liguori
>            Priority: Trivial
>
> "The toURL() method of File does not properly escape characters that aren't valid in a URL." -- http://www.jguru.com/faq/view.jsp?EID=1280051
> As such, the following sample project display warning due to lines constructed as such:
>    wsdlURL = wsdlFile.toURL();
> The recommendation is to update the source in the listed projects as such (as appropriate):
>    wsdlURL = wsdlFile.toURI().toURL(); 
> Affected sample projects:
> callback
> configuration_interceptor
> in_jvm_transport
> jax_rs_basic_https
> jaxws_async
> jaxws_dispatch_provider
> jaxws_handlers
> js_browser_client_simple
> js_client
> mtom
> soap_header
> ws_addressing
> ws_rm
> wsdl_first
> wsdl_first_dynamic_client
> wsdl_first_https
> wsdl_first_pure_xml
> wsdl_first_rpclit
> wsdl_first_soap12
> wsdl_first_xml_wrapped
> wsdl_first_xmlbeans
> wssec_ut_policy
> Note: I did not supply diffs, as it's far easier for someone with commit access to pass through the files and make the simple updates.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-3683) CXF Examples (multiple), Warnings: The method toURL() from the type File is deprecated

Posted by "Robert Liguori (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070155#comment-13070155 ] 

Robert Liguori commented on CXF-3683:
-------------------------------------

The warning badges are shown in Eclipse IDE SDK 3.7.0 on top of the associate folder/file nodes for the deprecated methods. 



> CXF Examples (multiple), Warnings: The method toURL() from the type File is deprecated
> --------------------------------------------------------------------------------------
>
>                 Key: CXF-3683
>                 URL: https://issues.apache.org/jira/browse/CXF-3683
>             Project: CXF
>          Issue Type: Improvement
>          Components: Samples
>    Affects Versions: 2.4.1
>         Environment: Mulitple CXF Sample Projects
> Eclipse IDE SDK 3.7.0 
>            Reporter: Robert Liguori
>            Priority: Trivial
>
> This is not necessarily an issue, though trying to achieve the goal of removing all warnings from the sample projects, this would be a nice-to-have.
> "The toURL() method of File does not properly escape characters that aren't valid in a URL." -- http://www.jguru.com/faq/view.jsp?EID=1280051
> As such, the following sample project display warning due to lines constructed as such:
>    wsdlURL = wsdlFile.toURL();
> The recommendation is to update the source in the listed projects as such (as appropriate):
>    wsdlURL = wsdlFile.toURI().toURL(); 
> Affected sample projects:
> callback
> configuration_interceptor
> in_jvm_transport
> jax_rs_basic_https
> jaxws_async
> jaxws_dispatch_provider
> jaxws_handlers
> js_browser_client_simple
> js_client
> mtom
> soap_header
> ws_addressing
> ws_rm
> wsdl_first
> wsdl_first_dynamic_client
> wsdl_first_https
> wsdl_first_pure_xml
> wsdl_first_rpclit
> wsdl_first_soap12
> wsdl_first_xml_wrapped
> wsdl_first_xmlbeans
> wssec_ut_policy
> Note: I did not supply diffs, as it's far easier for someone with commit access to pass through the files and make the simple updates.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (CXF-3683) CXF Examples (multiple), Warnings: The method toURL() from the type File is deprecated

Posted by "Robert Liguori (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Liguori closed CXF-3683.
-------------------------------

    Resolution: Not A Problem

This issue was marked as trivial, as it is.

Based on Glen's comment, I'm closing this issue:

"Just because this IDE or that IDE is coded to moan about a programmatic choice doesn't necessarily mean we need to change the code"

> CXF Examples (multiple), Warnings: The method toURL() from the type File is deprecated
> --------------------------------------------------------------------------------------
>
>                 Key: CXF-3683
>                 URL: https://issues.apache.org/jira/browse/CXF-3683
>             Project: CXF
>          Issue Type: Improvement
>          Components: Samples
>    Affects Versions: 2.4.1
>         Environment: Mulitple CXF Sample Projects
> Eclipse IDE SDK 3.7.0 
>            Reporter: Robert Liguori
>            Priority: Trivial
>
> "The toURL() method of File does not properly escape characters that aren't valid in a URL." -- http://www.jguru.com/faq/view.jsp?EID=1280051
> As such, the following sample project display warning due to lines constructed as such:
>    wsdlURL = wsdlFile.toURL();
> The recommendation is to update the source in the listed projects as such (as appropriate):
>    wsdlURL = wsdlFile.toURI().toURL(); 
> Affected sample projects:
> callback
> configuration_interceptor
> in_jvm_transport
> jax_rs_basic_https
> jaxws_async
> jaxws_dispatch_provider
> jaxws_handlers
> js_browser_client_simple
> js_client
> mtom
> soap_header
> ws_addressing
> ws_rm
> wsdl_first
> wsdl_first_dynamic_client
> wsdl_first_https
> wsdl_first_pure_xml
> wsdl_first_rpclit
> wsdl_first_soap12
> wsdl_first_xml_wrapped
> wsdl_first_xmlbeans
> wssec_ut_policy
> Note: I did not supply diffs, as it's far easier for someone with commit access to pass through the files and make the simple updates.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CXF-3683) CXF Examples (multiple), Warnings: The method toURL() from the type File is deprecated

Posted by "Robert Liguori (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Liguori updated CXF-3683:
--------------------------------

    Environment: 
Mulitple CXF Sample Projects
Eclipse IDE SDK 3.7.0 

  was:Mulitple CXF Sample Projects


> CXF Examples (multiple), Warnings: The method toURL() from the type File is deprecated
> --------------------------------------------------------------------------------------
>
>                 Key: CXF-3683
>                 URL: https://issues.apache.org/jira/browse/CXF-3683
>             Project: CXF
>          Issue Type: Improvement
>          Components: Samples
>    Affects Versions: 2.4.1
>         Environment: Mulitple CXF Sample Projects
> Eclipse IDE SDK 3.7.0 
>            Reporter: Robert Liguori
>            Priority: Trivial
>
> This is not necessarily an issue, though trying to achieve the goal of removing all warnings from the sample projects, this would be a nice-to-have.
> "The toURL() method of File does not properly escape characters that aren't valid in a URL." -- http://www.jguru.com/faq/view.jsp?EID=1280051
> As such, the following sample project display warning due to lines constructed as such:
>    wsdlURL = wsdlFile.toURL();
> The recommendation is to update the source in the listed projects as such (as appropriate):
>    wsdlURL = wsdlFile.toURI().toURL(); 
> Affected sample projects:
> callback
> configuration_interceptor
> in_jvm_transport
> jax_rs_basic_https
> jaxws_async
> jaxws_dispatch_provider
> jaxws_handlers
> js_browser_client_simple
> js_client
> mtom
> soap_header
> ws_addressing
> ws_rm
> wsdl_first
> wsdl_first_dynamic_client
> wsdl_first_https
> wsdl_first_pure_xml
> wsdl_first_rpclit
> wsdl_first_soap12
> wsdl_first_xml_wrapped
> wsdl_first_xmlbeans
> wssec_ut_policy
> Note: I did not supply diffs, as it's far easier for someone with commit access to pass through the files and make the simple updates.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira