You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/06 02:53:14 UTC
[GitHub] [flink] wuchong commented on a change in pull request #12819: [FLINK-18440][table-planner-blink] Allow ROW_NUMBER function: ROW/RANGE with RANK, DENSE_RANK or ROW_NUMBER functions
wuchong commented on a change in pull request #12819:
URL: https://github.com/apache/flink/pull/12819#discussion_r449959578
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/calcite/sql/SqlRankFunction.java
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.calcite.sql;
Review comment:
It's not suggested to rewrite a Calcite class, unless it's the only way to do it. Otherwise, the code will be hard to mantain.
In this case, we can have a `FlinkSqlRankFunction` which is located in flink package.
Besides, we should create an issue in Calcite, and link the issue in the `FlinkSqlRankFunction` to tell the maintainer to remove this class once the issue is fixed.
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/TableScanTest.scala
##########
@@ -357,4 +357,33 @@ class TableScanTest extends TableTestBase {
|)
""".stripMargin)
}
+
+ @Test
+ def testRowNumOverWindow(): Unit = {
+ util.addTable(
+ """
+ |CREATE TABLE test_source (
+ | name STRING,
+ | eat STRING,
+ | age BIGINT
+ |) WITH (
+ | 'connector' = 'values'
+ |)
+ """.stripMargin)
+
+ util.tableEnv.executeSql("create view test as select name, eat ,sum(age) as cnt from test_source group by name,eat")
+ util.tableEnv.executeSql("create view resultsssss as select *, ROW_NUMBER() OVER (PARTITION BY name ORDER BY cnt DESC) as row_num from test")
+ util.addTable(
+ s"""
+ |create table sink (
+ |name varchar,
+ |eat varchar,
+ |cnt bigint
+ |)
+ |with(
+ |'connector' = 'print'
+ |)
+ """.stripMargin)
+ util.verifyPlanInsert("insert into sink select name,eat,cnt from resultsssss where row_num <= 3")
Review comment:
Don't need INSERT INTO. You can just call `util.verifyPlan("SELECT ...")`
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/TableScanTest.scala
##########
@@ -357,4 +357,33 @@ class TableScanTest extends TableTestBase {
|)
""".stripMargin)
}
+
+ @Test
+ def testRowNumOverWindow(): Unit = {
+ util.addTable(
+ """
+ |CREATE TABLE test_source (
+ | name STRING,
+ | eat STRING,
+ | age BIGINT
+ |) WITH (
+ | 'connector' = 'values'
+ |)
+ """.stripMargin)
+
+ util.tableEnv.executeSql("create view test as select name, eat ,sum(age) as cnt from test_source group by name,eat")
+ util.tableEnv.executeSql("create view resultsssss as select *, ROW_NUMBER() OVER (PARTITION BY name ORDER BY cnt DESC) as row_num from test")
Review comment:
Please give a meaningful view name.
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/calcite/sql/SqlRankFunction.java
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.calcite.sql;
+
+import org.apache.calcite.sql.type.OperandTypes;
+import org.apache.calcite.sql.type.ReturnTypes;
+import org.apache.calcite.sql.type.SqlReturnTypeInference;
+import org.apache.calcite.util.Optionality;
+
+/**
+ * Operator which aggregates sets of values into a result.
+ */
+public class SqlRankFunction extends SqlAggFunction {
+ //~ Constructors -----------------------------------------------------------
+
+ @Deprecated
+ public SqlRankFunction(boolean requiresOrder, SqlKind kind) {
+ this(kind, ReturnTypes.INTEGER, requiresOrder);
+ }
+
+ public SqlRankFunction(SqlKind kind, SqlReturnTypeInference returnTypes,
+ boolean requiresOrder) {
+ super(kind.name(), null, kind, returnTypes, null,
+ OperandTypes.NILADIC, SqlFunctionCategory.NUMERIC, requiresOrder,
+ true, Optionality.FORBIDDEN);
+ }
+
+ //~ Methods ----------------------------------------------------------------
+
+ @Override public boolean allowsFraming() {
+ return true;
Review comment:
Please add comment why we have to override this method and allow framing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org