You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Gary D. Gregory (JIRA)" <ji...@apache.org> on 2011/09/02 16:52:10 UTC

[jira] [Updated] (CXF-3789) org.apache.cxf.endpoint.ClientImpl.invoke(BindingOperationInfo, Object[], Exchange) wastes cycles

     [ https://issues.apache.org/jira/browse/CXF-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary D. Gregory updated CXF-3789:
---------------------------------

    Attachment: ClientImpl.diff

trunk patch.

> org.apache.cxf.endpoint.ClientImpl.invoke(BindingOperationInfo, Object[], Exchange) wastes cycles
> -------------------------------------------------------------------------------------------------
>
>                 Key: CXF-3789
>                 URL: https://issues.apache.org/jira/browse/CXF-3789
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 2.4.2
>         Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
> Maven home: C:\Java\apache-maven-3.0.3\bin\..
> Java version: 1.6.0_24, vendor: Sun Microsystems Inc.
> Java home: C:\Program Files\Java\jdk1.6.0_24\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>            Reporter: Gary D. Gregory
>         Attachments: ClientImpl.diff
>
>
> While debugging our server, I saw in {{org.apache.cxf.endpoint.ClientImpl.invoke(BindingOperationInfo, Object[], Exchange)}}:
> {code:java}
> Map<String, Object> resp = new HashMap<String, Object>();
> resp.clear();
> {code}
> That's silly and a noop. Attaching patch to remove and do:
> {code:java}
> Map<String, Object> resp = new HashMap<String, Object>();
> {code}
> If you want an empty map to avoid wasting space for a rarely used feature, perhaps use:
> {code:java}
> Map<String, Object> resp = new HashMap<String, Object>(0);
> {code}
> or:
> {code:java}
> Map<String, Object> resp = new HashMap<String, Object>(1);
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira