[jira] Commented: (ZOOKEEPER-551) unnecessary SetWatches message on new session

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774483#action_12774483 ] 

Hadoop QA commented on ZOOKEEPER-551:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12424236/ZOOKEEPER-551.patch
  against trunk revision 833559.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/54/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/54/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/54/console

This message is automatically generated.

> unnecessary SetWatches message on new session
> ---------------------------------------------
>
>                 Key: ZOOKEEPER-551
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-551
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client, java client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Minor
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-551.patch
>
>
> The java client is sending a SetWatches message even on a new session (always empty). Additionally SetWatches is called
> even in the case of re-establishing session, however no watches are set. The code should check for watches before
> sending this (ie don't send empty setwatches). I see this on java, investigate c as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.