[GitHub] [hive] pvary commented on a change in pull request #2317: HIVE-25162: Add support for CREATE TABLE ... STORED BY ICEBERG statements

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2317:
URL: https://github.com/apache/hive/pull/2317#discussion_r639553457



##########
File path: iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java
##########
@@ -239,6 +240,36 @@ public void testCreateDropTableNonDefaultCatalog() throws TException, Interrupte
     );
   }
 
+  @Test
+  public void testCreateTableStoredByIceberg() {
+    TableIdentifier identifier = TableIdentifier.of("default", "customers");
+    String query = String.format("CREATE EXTERNAL TABLE customers (customer_id BIGINT, first_name STRING, last_name " +
+        "STRING) STORED BY %s %s TBLPROPERTIES ('%s'='%s')",
+        "ICEBERG",

Review comment:
       I would change most of the test to `STORED BY ICEBERG` and keep only a few with the original class name.
   Also I would like to try out `stored by iCeBerG`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org