You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2019/02/20 01:18:38 UTC

[GitHub] nwangtw commented on a change in pull request #3195: 2D(RAM, CPU) Vector Binpacking (FirstFit Decreasing) Packing

nwangtw commented on a change in pull request #3195: 2D(RAM, CPU) Vector Binpacking (FirstFit Decreasing) Packing
URL: https://github.com/apache/incubator-heron/pull/3195#discussion_r258295666
 
 

 ##########
 File path: heron/packing/src/java/org/apache/heron/packing/binpacking/TwoDimensionVectorBinPacking.java
 ##########
 @@ -0,0 +1,379 @@
+/**
 
 Review comment:
   I am feeling that it is fine to keep the old name, since it is BinPacking anyway. Also if any user was using BinPacking before, renaming would require them to update their config which is not convenient. The new code works very similar to the old logic anyway.
   
   Just my 2 cents.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services