You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/29 13:43:35 UTC
[GitHub] [airflow] eladkal opened a new issue #19877: Refactor poll_query_status in EMRContainerHook
eladkal opened a new issue #19877:
URL: https://github.com/apache/airflow/issues/19877
### Body
The goal is to refactor the code so that we can remove this TODO
https://github.com/apache/airflow/blob/7640ba4e8ee239d6e2bbf950d53d624b9df93059/airflow/providers/amazon/aws/hooks/emr_containers.py#L174-L176
More information about the concerns can be found on https://github.com/apache/airflow/pull/16766#discussion_r668089559
### Committer
- [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on issue #19877: Refactor poll_query_status in EMRContainerHook
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on issue #19877:
URL: https://github.com/apache/airflow/issues/19877#issuecomment-1007002023
@patrikhv - It looks to me like adding in the explicit "is it a terminal state?" check is all that is needed here. You want to put in the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #19877: Refactor poll_query_status in EMRContainerHook
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #19877:
URL: https://github.com/apache/airflow/issues/19877#issuecomment-981671223
Go ahead!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dacort commented on issue #19877: Refactor poll_query_status in EMRContainerHook
Posted by GitBox <gi...@apache.org>.
dacort commented on issue #19877:
URL: https://github.com/apache/airflow/issues/19877#issuecomment-981928763
Thanks @patrikhv - let me know if I can help in any way! (original PR contributor and EMR team member)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] patrikhv commented on issue #19877: Refactor poll_query_status in EMRContainerHook
Posted by GitBox <gi...@apache.org>.
patrikhv commented on issue #19877:
URL: https://github.com/apache/airflow/issues/19877#issuecomment-981670801
Hi. I would like to work on this issue. Can you assign it to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #19877: Refactor poll_query_status in EMRContainerHook
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #19877:
URL: https://github.com/apache/airflow/issues/19877#issuecomment-1026210345
@ferruzzi since patrikhv is not working on it. Do you want to put a PR to solve this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on issue #19877: Refactor poll_query_status in EMRContainerHook
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on issue #19877:
URL: https://github.com/apache/airflow/issues/19877#issuecomment-1006989009
Had a chat with dacort. They mentioned that the change they had in mind was that we don't actually confirm that the state is at a terminal state, only that it is not at an intermediate state. I can't think of any other changes I'd make to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] victorphoenix3 commented on issue #19877: Refactor poll_query_status in EMRContainerHook
Posted by GitBox <gi...@apache.org>.
victorphoenix3 commented on issue #19877:
URL: https://github.com/apache/airflow/issues/19877#issuecomment-1031100836
Hello! I am new to the community and would like to take this on as my first issue. May I submit a PR for this? @eladkal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #19877: Refactor poll_query_status in EMRContainerHook
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #19877:
URL: https://github.com/apache/airflow/issues/19877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] patrikhv commented on issue #19877: Refactor poll_query_status in EMRContainerHook
Posted by GitBox <gi...@apache.org>.
patrikhv commented on issue #19877:
URL: https://github.com/apache/airflow/issues/19877#issuecomment-988284027
Hi, I am working on that, but I do not have any idea how to refactor it. I already just did a more explicit call, if the query is in a completed stage. Can you give me any tips?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on issue #19877: Refactor poll_query_status in EMRContainerHook
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on issue #19877:
URL: https://github.com/apache/airflow/issues/19877#issuecomment-1026316991
@eladkal I have a few other things I'm working on. I can have a look when I get time, but it'll likely be a couple weeks unless somebody gets to it before then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #19877: Refactor poll_query_status in EMRContainerHook
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #19877:
URL: https://github.com/apache/airflow/issues/19877#issuecomment-1031214622
Feel fre to attempt it :). Maybe @ferruzzi will be able to help with reviewing it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org