You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/12/10 03:17:07 UTC
[GitHub] [inlong] wangpeix opened a new pull request, #6814: [INLONG-6813][Sort] MetricStateUtils threw NPE when write to es and no dirtyRecordsOut counter
wangpeix opened a new pull request, #6814:
URL: https://github.com/apache/inlong/pull/6814
### Prepare a Pull Request
- Title: [INLONG-6813][Sort] MetricStateUtils threw NPE when write to es and no dirtyRecordsOut counter
- Fixes #6813
### Motivation
Fix metricStateUtils threw NPE when write to es and no dirtyRecordsOut counter.
### Modifications
Register a `DIRTY` counter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] wangpeix commented on pull request #6814: [INLONG-6813][Sort] MetricStateUtils threw NPE when write to es and no dirtyRecordsOut counter
Posted by GitBox <gi...@apache.org>.
wangpeix commented on PR #6814:
URL: https://github.com/apache/inlong/pull/6814#issuecomment-1345477307
@gong ok, thanks, I will optimize my code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] wangpeix commented on pull request #6814: [INLONG-6813][Sort] MetricStateUtils threw NPE when write to es and no dirtyRecordsOut counter
Posted by GitBox <gi...@apache.org>.
wangpeix commented on PR #6814:
URL: https://github.com/apache/inlong/pull/6814#issuecomment-1347556679
@gong The code has been optimized, please help me review it again, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #6814: [INLONG-6813][Sort] MetricStateUtils threw NPE when write to es and no dirtyRecordsOut counter
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #6814:
URL: https://github.com/apache/inlong/pull/6814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on pull request #6814: [INLONG-6813][Sort] MetricStateUtils threw NPE when write to es and no dirtyRecordsOut counter
Posted by GitBox <gi...@apache.org>.
gong commented on PR #6814:
URL: https://github.com/apache/inlong/pull/6814#issuecomment-1345460999
`https://github.com/apache/inlong/blob/master/inlong-sort/sort-connectors/elasticsearch-base/src/main/java/org/apache/inlong/sort/elasticsearch/table/RowElasticsearchSinkFunction.java` and
`https://github.com/apache/inlong/blob/master/inlong-sort/sort-connectors/elasticsearch-base/src/main/java/org/apache/inlong/sort/elasticsearch/ElasticsearchSinkBase.java`
will register duplication dirty metric, It will lead metric duplication error when set metric report.
So I suggest modify `MetricStateUtils` to add judge null. @EMsnap will update elasticsearch metric computing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] wangpeix commented on pull request #6814: [INLONG-6813][Sort] MetricStateUtils threw NPE when write to es and no dirtyRecordsOut counter
Posted by GitBox <gi...@apache.org>.
wangpeix commented on PR #6814:
URL: https://github.com/apache/inlong/pull/6814#issuecomment-1346033567
@gong thanks, I will optimize it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org