[GitHub] [accumulo] EdColeman commented on issue #2618: Rename property

[GitBox <gi...@apache.org>]

EdColeman commented on issue #2618:
URL: https://github.com/apache/accumulo/issues/2618#issuecomment-1104368037

   This might be more than just a simple rename. There are considerations of current usages, how and where the name / value is used and the expected behavior of existing code that uses the current values.
   
   For the original issue as stated, one possibility would be to would be to rename both the property enum name (GENERAL_SIMPLETIMER_THREADPOOL_SIZE) and the string value used as a key (general.server.simpletimer.threadpool.size) to something that reflects the current usage.  
   
   However, there are additional considerations:
   
   It may be better (necessary?) to deprecate the current name with the replacement, but allow either to be used.
   
   The change would need to replace the enum name in the code base and then any scripts that use the string value should also be modified.  This should also be documented in the release notes so that users know the change occurred.
   
   For current installations that may use the current name, it would be necessary to rename the property name (key) that is stored in ZooKeeper during the upgrade processing so that the "saved" value would be transformed and remain valid any code that has this change. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org