You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/12 21:43:57 UTC
[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request
#5147: Support default star-tree
mcvsubbu commented on a change in pull request #5147: Support default star-tree
URL: https://github.com/apache/incubator-pinot/pull/5147#discussion_r391916643
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/generator/SegmentGeneratorConfig.java
##########
@@ -190,13 +190,17 @@ public SegmentGeneratorConfig(@Nullable TableConfig tableConfig, Schema schema)
_segmentPartitionConfig = indexingConfig.getSegmentPartitionConfig();
// Star-tree V2 configs
- List<StarTreeIndexConfig> starTreeIndexConfigs = indexingConfig.getStarTreeIndexConfigs();
- if (starTreeIndexConfigs != null && !starTreeIndexConfigs.isEmpty()) {
- List<StarTreeV2BuilderConfig> starTreeV2BuilderConfigs = new ArrayList<>(starTreeIndexConfigs.size());
- for (StarTreeIndexConfig starTreeIndexConfig : starTreeIndexConfigs) {
- starTreeV2BuilderConfigs.add(StarTreeV2BuilderConfig.fromIndexConfig(starTreeIndexConfig));
+ if (indexingConfig.isEnableDefaultStarTree()) {
Review comment:
If both are defined, you should pay attention to the specific start tree definition requested. This will keep backward compat also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org