You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by bb...@apache.org on 2019/06/25 22:22:59 UTC

[kafka] branch trunk updated: Minor: code enhancment (#6999)

This is an automated email from the ASF dual-hosted git repository.

bbejeck pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 5216839  Minor: code enhancment (#6999)
5216839 is described below

commit 5216839d8bcda5c00825a0f4be866a525d948da8
Author: khairy <kh...@gmail.com>
AuthorDate: Tue Jun 25 23:22:44 2019 +0100

    Minor: code enhancment (#6999)
    
    
    Reviewers: Bill Bejeck <bb...@gmail.com>
---
 .../kafka/streams/kstream/internals/suppress/TimeDefinitions.java       | 2 +-
 .../src/main/java/org/apache/kafka/streams/state/internals/Maybe.java   | 2 +-
 .../java/org/apache/kafka/streams/tests/BrokerCompatibilityTest.java    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/suppress/TimeDefinitions.java b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/suppress/TimeDefinitions.java
index b37bcf6..674114f 100644
--- a/streams/src/main/java/org/apache/kafka/streams/kstream/internals/suppress/TimeDefinitions.java
+++ b/streams/src/main/java/org/apache/kafka/streams/kstream/internals/suppress/TimeDefinitions.java
@@ -23,7 +23,7 @@ final class TimeDefinitions {
     private TimeDefinitions() {}
 
     enum TimeDefinitionType {
-        RECORD_TIME, WINDOW_END_TIME;
+        RECORD_TIME, WINDOW_END_TIME
     }
 
     /**
diff --git a/streams/src/main/java/org/apache/kafka/streams/state/internals/Maybe.java b/streams/src/main/java/org/apache/kafka/streams/state/internals/Maybe.java
index c292c17..8f95ecf 100644
--- a/streams/src/main/java/org/apache/kafka/streams/state/internals/Maybe.java
+++ b/streams/src/main/java/org/apache/kafka/streams/state/internals/Maybe.java
@@ -81,7 +81,7 @@ public final class Maybe<T> {
     @Override
     public String toString() {
         if (defined) {
-            return "DefinedMaybe{" + String.valueOf(nullableValue) + "}";
+            return "DefinedMaybe{" + nullableValue + "}";
         } else {
             return "UndefinedMaybe{}";
         }
diff --git a/streams/src/test/java/org/apache/kafka/streams/tests/BrokerCompatibilityTest.java b/streams/src/test/java/org/apache/kafka/streams/tests/BrokerCompatibilityTest.java
index 47f74d8..0c9889a 100644
--- a/streams/src/test/java/org/apache/kafka/streams/tests/BrokerCompatibilityTest.java
+++ b/streams/src/test/java/org/apache/kafka/streams/tests/BrokerCompatibilityTest.java
@@ -121,7 +121,7 @@ public class BrokerCompatibilityTest {
         producerProperties.put(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG, StringSerializer.class);
 
         try {
-            try (final KafkaProducer<String, String> producer = new KafkaProducer<>(producerProperties);) {
+            try (final KafkaProducer<String, String> producer = new KafkaProducer<>(producerProperties)) {
                 producer.send(new ProducerRecord<>(SOURCE_TOPIC, "key", "value"));
 
                 System.out.println("wait for result");