[jira] Updated: (DERBY-1456) Network Server agentError calls log only to console and are hard to diagnose

["Sunitha Kambhampati (JIRA)" <de...@db.apache.org>]

     [ http://issues.apache.org/jira/browse/DERBY-1456?page=all ]

Sunitha Kambhampati updated DERBY-1456:
---------------------------------------

    Attachment: derby1456.diff.txt
                derby1456.stat.txt
                1456_notes.txt

I am attaching a patch 'derby1456.diff.txt' and the stat file 'derby1456.stat.txt' .

For notes about this issue, please see the attached derby1456_notes.txt.

This patch does the following:
1. Use the correct errorCodePoint for agent errors. CodePoint.AGNPRMRM. Agent errors will be logged ok.
2. In agent errors, retrieve the descriptive string passed in as argument.
3. override Exception.getMessage() , so call to DRDAProtocolException.getMessage() will return the diagnostic message.

This is a network server only change. The server tests (derbynetclientmats and derbynetmats) ran ok on ibm142/linux. 

Can someone please review this patch. 

Thanks,
Sunitha. 

> Network Server agentError calls log only to console and are hard to diagnose
> ----------------------------------------------------------------------------
>
>                 Key: DERBY-1456
>                 URL: http://issues.apache.org/jira/browse/DERBY-1456
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Server
>    Affects Versions: 10.2.0.0
>            Reporter: Bryan Pendleton
>            Priority: Minor
>         Attachments: 1456_notes.txt, derby1456.diff.txt, derby1456.stat.txt
>
>
> The Network Server code uses an assertion-check utility routine called agentError()
> under certain circumstances. When these agentError() calls arise, for example as
> in DERBY-1454, there is no server side logging of the error except to the console. 
> The user application  that hit DERBY-1454 had not been capturing console output and there 
> was no clue in the derby.log, this made the problem hard to track down when they 
> suddenly hit this boundary deep within their stress tests.
> See also DERBY-743 for another issue with Network Server's agentError routine.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira