You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2019/06/13 08:45:53 UTC
[Impala-ASF-CR](2.x) IMPALA-7257. Support Kudu tables in LocalCatalog
Hello Tianyi Wang, Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13630
to review the following change.
Change subject: IMPALA-7257. Support Kudu tables in LocalCatalog
......................................................................
IMPALA-7257. Support Kudu tables in LocalCatalog
This adds support for querying Kudu tables when --use_local_catalog is
enabled.
With this change, most of the kudu e2e tests pass. Those that don't are
related to missing support for CREATE TABLE AS SELECT, which currently
has some downcasts to 'Db' causing issues. That will be addressed in a
separate patch along with fixing CTAS for FS-backed tables.
Change-Id: I5b6a317ee895e43e00ade953e814867b56b4e6dd
Reviewed-on: http://gerrit.cloudera.org:8080/10912
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Tianyi Wang <tw...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddDropRangePartitionStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddPartitionStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddReplaceColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetFileFormatStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetLocationStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/main/java/org/apache/impala/analysis/KuduPartitionExpr.java
M fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java
M fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java
A fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java
A fe/src/main/java/org/apache/impala/catalog/local/LocalKuduTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java
M fe/src/main/java/org/apache/impala/catalog/local/LocalView.java
M fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java
M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
M fe/src/main/java/org/apache/impala/planner/Planner.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M fe/src/main/java/org/apache/impala/planner/TableSink.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/util/KuduUtil.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
33 files changed, 697 insertions(+), 343 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/13630/1
--
To view, visit http://gerrit.cloudera.org:8080/13630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b6a317ee895e43e00ade953e814867b56b4e6dd
Gerrit-Change-Number: 13630
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-7257. Support Kudu tables in LocalCatalog
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13630 )
Change subject: IMPALA-7257. Support Kudu tables in LocalCatalog
......................................................................
Patch Set 1:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java
File fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java:
http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/main/java/org/apache/impala/catalog/FeKuduTable.java@146
PS1, Line 146: kuduTable.getTabletsLocations(BackendConfig.INSTANCE.getKuduClientTimeoutMs());
line too long (91 > 90)
http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
File fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java:
http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@196
PS1, Line 196: " bool_col BOOLEAN NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" +
line too long (93 > 90)
http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@197
PS1, Line 197: " tinyint_col TINYINT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" +
line too long (96 > 90)
http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@198
PS1, Line 198: " smallint_col SMALLINT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" +
line too long (98 > 90)
http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@200
PS1, Line 200: " bigint_col BIGINT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" +
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@201
PS1, Line 201: " float_col FLOAT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" +
line too long (92 > 90)
http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@202
PS1, Line 202: " double_col DOUBLE NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" +
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@203
PS1, Line 203: " date_string_col STRING NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" +
line too long (99 > 90)
http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@204
PS1, Line 204: " string_col STRING NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" +
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/13630/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@205
PS1, Line 205: " timestamp_col TIMESTAMP NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" +
line too long (100 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/13630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6a317ee895e43e00ade953e814867b56b4e6dd
Gerrit-Change-Number: 13630
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 08:55:25 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](2.x) IMPALA-7257. Support Kudu tables in LocalCatalog
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has abandoned this change. ( http://gerrit.cloudera.org:8080/13630 )
Change subject: IMPALA-7257. Support Kudu tables in LocalCatalog
......................................................................
Abandoned
Sorry that I accidentally submit these patches. There're clean for cherry-pick so don't need for review.
--
To view, visit http://gerrit.cloudera.org:8080/13630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: abandon
Gerrit-Change-Id: I5b6a317ee895e43e00ade953e814867b56b4e6dd
Gerrit-Change-Number: 13630
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>