You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2016/01/20 20:12:19 UTC
[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Implement splash...
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/76
CB-8056 Implement splashscreen for Windows platform
[Jira issue](https://issues.apache.org/jira/browse/CB-8056)
The plugin implementation has been moved to the platform code
Documented SplashScreenBackgroundColor preference for Windows
Updated the docs
Related to apache/cordova-windows#141
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen CB-8056
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/76.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #76
----
commit 5ffb4cb771b11bffc0c4f6a707563b20e7d19613
Author: daserge <v-...@microsoft.com>
Date: 2016-01-14T16:15:06Z
CB-8056 Implement splashscreen for Windows platform
The plugin implementation has been moved to the platform code
Documented SplashScreenBackgroundColor preference for Windows
Updated the docs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Implement splash...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213589583
it does
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Implement splash...
Posted by RobPosener <gi...@git.apache.org>.
Github user RobPosener commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213588273
Spinner has never worked in Windows 10
It should.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Implement splash...
Posted by chrigi <gi...@git.apache.org>.
Github user chrigi commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-178437613
@daserge
I tried it on Windows Mobile 10 (windows engine) Lumia 950 XL.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Implement splash...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/76#discussion_r50966450
--- Diff: README.md ---
@@ -123,13 +123,26 @@ window.setTimeout(function () {
}, splashDuration - fadeDuration);
```
-### iOS Quirks
+### iOS and Windows Quirks
- `ShowSplashScreenSpinner` (boolean, defaults to `true`): Set to `false`
to hide the splash-screen spinner.
<preference name="ShowSplashScreenSpinner" value="false"/>
+### Windows Quirks
+
+- `SplashScreenSpinnerColor` (string, defaults to system accent color): hash, rgb notation or CSS color name.
+
+ <preference name="SplashScreenSpinnerColor" value="#242424"/>
+ <preference name="SplashScreenSpinnerColor" value="DarkRed"/>
+ <preference name="SplashScreenSpinnerColor" value="rgb(50,128,128)"/>
+
+- `SplashScreenBackgroundColor` (string, defaults to #464646): hex notation.
+
+ <preference name="SplashScreenBackgroundColor" value="0xFFFFFFFF"/>
+
+
--- End diff --
@SunboX, thanks, there is a separate issue for that: https://issues.apache.org/jira/browse/CB-9287
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Implement splash...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-176310415
@chrigi, thanks for your feedback.
> It does not respect the "ShowSplashScreenSpinner" preference from the config.xml
That's strange, it should - I will take a look this weekend.
> The spinner seems to slightly overlap the image
Which platform(s) has this issue? (wp8.1, wp10, win8.1, win10)
What screen size/resolution?
> It does not set the statusbar color to the splashScreenBackgroundColor
That's a good point, thanks, I will also try to look into this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Implement splash...
Posted by SunboX <gi...@git.apache.org>.
Github user SunboX commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/76#discussion_r50958608
--- Diff: README.md ---
@@ -123,13 +123,26 @@ window.setTimeout(function () {
}, splashDuration - fadeDuration);
```
-### iOS Quirks
+### iOS and Windows Quirks
- `ShowSplashScreenSpinner` (boolean, defaults to `true`): Set to `false`
to hide the splash-screen spinner.
<preference name="ShowSplashScreenSpinner" value="false"/>
+### Windows Quirks
+
+- `SplashScreenSpinnerColor` (string, defaults to system accent color): hash, rgb notation or CSS color name.
+
+ <preference name="SplashScreenSpinnerColor" value="#242424"/>
+ <preference name="SplashScreenSpinnerColor" value="DarkRed"/>
+ <preference name="SplashScreenSpinnerColor" value="rgb(50,128,128)"/>
+
+- `SplashScreenBackgroundColor` (string, defaults to #464646): hex notation.
+
+ <preference name="SplashScreenBackgroundColor" value="0xFFFFFFFF"/>
+
+
--- End diff --
Shouldn't it be mentioned to add "Scale 100", "Scale 140" and "Scale 180" images? (620 x 300 px, 868 x 420 px and 1116 x 540 px, https://msdn.microsoft.com/en-us/library/windows/apps/mt187306.aspx)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Implement splash...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/76
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Implement splash...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213673802
@RobPosener, did the issue happen for you in the old or in the current version?
On Windows 10 Mobile or Desktop?
Have you tried to change the spinner color?
`<preference name="SplashScreenSpinnerColor" value="#d03932" />`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Implement splash...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213581077
Verified, and merged. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Implement splash...
Posted by SunboX <gi...@git.apache.org>.
Github user SunboX commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-175494339
That's great! Just was looking for a way how to set the background color for UWP splash screen (Windows 10 Mobile). Thanks for your work! :+1: :heart:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Implement splash...
Posted by RobPosener <gi...@git.apache.org>.
Github user RobPosener commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213675499
I've been developing for the Android platform since January 2014 (and the
splash screen spinner now works there) and the Windows platform (on a
desktop Windows 10) using Visual Studio 2015 (now with Update 2) since
October, 2015 and the splash screen spinner has never worked for the
Windows platform. I've tried a few variations in my config.xml file over
the months but have never been able to get the spinner to work.
FYI, my complete config.xml for windows platform parameters are:
<platform name="windows"> <icon height="150"
src="res/icons/windows/Logo.png" width="150" /> <icon height="30"
src="res/icons/windows/LogoSmall.png" width="30" /> <icon
height="50" src="res/icons/windows/LogoStore.png" width="50" />
<icon height="44" src="res/icons/windows/LogoStartScreen.png"
width="44" /> <splash height="300"
src="res/screens/windows/SplashScreen-620x300.png" width="620" />
<splash height="1920"
src="res/screens/windows/SplashScreen-1152x1920.png" width="1152" />
<preference name="SplashScreen" value="screen" /> <preference
name="SplashScreenDelay" value="75000" /> <preference
name="SplashScreenBackgroundColor" value="0x00000000" />
<preference name="SplashMaintainAspectRatio" value="true" />
<preference name="SplashShowOnlyFirstTime" value="false" />
<preference name="FadeSplashScreen" value="true" /> <preference
name="FadeSplashScreenDuration" value="1500" /> <preference
name="ShowSplashScreenSpinner" value="true" /> <preference
name="SplashScreenSpinnerColor" value="#242424" /> <preference
name="AutoHideSplashScreen" value="false" /> <preference
name="windows-target-version" value="10.0" /> <preference
name="windows-phone-target-version" value="10.0" /> </platform>
Regards
Rob
Regards
*Rob Posener*
0419 012 627
On 23 April 2016 at 16:22, Sergey Shakhnazarov <no...@github.com>
wrote:
> @RobPosener <https://github.com/RobPosener>, did the issue happen for you
> in the old or in the current version?
> On Windows 10 Mobile or Desktop?
> Have you tried to change the spinner color?
> <preference name="SplashScreenSpinnerColor" value="#d03932" />
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-213673802>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Implement splash...
Posted by chrigi <gi...@git.apache.org>.
Github user chrigi commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/76#issuecomment-176245101
Thanks for your work. I noticed the following:
- It does not respect the "ShowSplashScreenSpinner" preference from the config.xml
- The spinner seems to slightly overlap the image
- It does not set the statusbar color to the splashScreenBackgroundColor when calling .show() and restore the previous color when calling .hide() and when setting the statusbar color before hiding the splash screen it will change the color. This will probably need adjustments in the status bar plugin I think.
But I can absolutely use it like this. Thanks a LOT!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org