You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mjsax (via GitHub)" <gi...@apache.org> on 2025/01/10 02:57:56 UTC
[PR] KAFKA-8116: Update Kafka Streams archetype for Java 11 [kafka]
mjsax opened a new pull request, #18471:
URL: https://github.com/apache/kafka/pull/18471
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-8116: Update Kafka Streams archetype for Java 11 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #18471:
URL: https://github.com/apache/kafka/pull/18471#discussion_r1909731765
##########
streams/quickstart/java/src/main/resources/archetype-resources/pom.xml:
##########
@@ -30,7 +30,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<kafka.version>4.1.0-SNAPSHOT</kafka.version>
- <slf4j.version>1.7.36</slf4j.version>
Review Comment:
Side improvement: bump to latest stable version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-8116: Update Kafka Streams archetype for Java 11 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #18471:
URL: https://github.com/apache/kafka/pull/18471#discussion_r1909732242
##########
streams/quickstart/java/src/main/resources/archetype-resources/pom.xml:
##########
@@ -47,20 +47,15 @@
</repository>
</repositories>
- <!--
- Execute "mvn clean package -Pbuild-jar"
Review Comment:
Goal `build-jar` does not exist... removing this comment... confusing
##########
streams/quickstart/java/src/main/resources/archetype-resources/pom.xml:
##########
@@ -47,20 +47,15 @@
</repository>
</repositories>
- <!--
- Execute "mvn clean package -Pbuild-jar"
- to build a jar file out of this project!
- -->
-
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.1</version>
Review Comment:
Side improvement: bump to latest version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-8116: Update Kafka Streams archetype for Java 11 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax merged PR #18471:
URL: https://github.com/apache/kafka/pull/18471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-8116: Update Kafka Streams archetype for Java 11 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #18471:
URL: https://github.com/apache/kafka/pull/18471#issuecomment-2584916779
Merged to `trunk` and cherry-picked to `4.0` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-8116: Update Kafka Streams archetype for Java 11 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #18471:
URL: https://github.com/apache/kafka/pull/18471#issuecomment-2583462697
Java 17:
```
Found 1 test failures:
FAILED ❌ EagerConsumerCoordinatorTest > testOutdatedCoordinatorAssignment()
Found 1 flaky test failures:
FLAKY ⚠️ PlaintextConsumerTest > testCoordinatorFailover(String, String).quorum=kraft.groupProtocol=consumer
```
`EagerConsumerCoordinatorTest` is not to me... \cc @lianetm @kirktrue @dajac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-8116: Update Kafka Streams archetype for Java 11 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #18471:
URL: https://github.com/apache/kafka/pull/18471#discussion_r1909734782
##########
streams/quickstart/java/src/main/resources/archetype-resources/pom.xml:
##########
@@ -47,41 +47,21 @@
</repository>
</repositories>
- <!--
- Execute "mvn clean package -Pbuild-jar"
- to build a jar file out of this project!
- -->
-
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.1</version>
+ <version>3.13.0</version>
<configuration>
- <source>1.8</source>
- <target>1.8</target>
+ <source>11</source>
+ <target>11</target>
</configuration>
</plugin>
</plugins>
<pluginManagement>
<plugins>
- <plugin>
- <artifactId>maven-compiler-plugin</artifactId>
- <configuration>
- <source>1.8</source>
- <target>1.8</target>
- <compilerId>jdt</compilerId>
Review Comment:
Removing the whole `<plugin>` section -- not sure why we set `jdt` instead of default `javac` originally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-8116: Update Kafka Streams archetype for Java 11 [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on PR #18471:
URL: https://github.com/apache/kafka/pull/18471#issuecomment-2584372556
Yeap, the flaky `EagerConsumerCoordinatorTest.testOutdatedCoordinatorAssignment` is tracked already https://issues.apache.org/jira/browse/KAFKA-15900 , and is indeed very flaky in trunk
https://ge.apache.org/scans/tests?search.buildOutcome=failure&search.names=Git%20branch&search.relativeStartTime=P28D&search.rootProjectNames=kafka&search.timeZoneId=America%2FToronto&search.values=trunk&tests.container=org.apache.kafka.clients.consumer.internals.EagerConsumerCoordinatorTest&tests.test=testOutdatedCoordinatorAssignment()
(adding more info to the Jira to see if it can be prioritized)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-8116: Update Kafka Streams archetype for Java 11 [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on code in PR #18471:
URL: https://github.com/apache/kafka/pull/18471#discussion_r1910375965
##########
streams/quickstart/java/src/main/resources/archetype-resources/pom.xml:
##########
@@ -47,41 +47,21 @@
</repository>
</repositories>
- <!--
- Execute "mvn clean package -Pbuild-jar"
- to build a jar file out of this project!
- -->
-
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.1</version>
+ <version>3.13.0</version>
<configuration>
- <source>1.8</source>
- <target>1.8</target>
+ <source>11</source>
+ <target>11</target>
Review Comment:
It would be good to set the release flag to 11 - that's the recommended way to do this kind of thing from Java 9 onwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org