You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by Thorsten Scherler <th...@juntadeandalucia.es> on 2007/09/20 18:08:45 UTC

Re: svn commit: r577427 - in /lucene/solr/trunk/client/java/solrj/test/org/apache/solr/client/solrj: LargeVolumeTestBase.java embedded/LargeVolumeEmbeddedTest.java embedded/LargeVolumeJettyTest.java

On Thu, 2007-09-20 at 11:24 -0400, Erik Hatcher wrote:
> On Sep 19, 2007, at 5:52 PM, Chris Hostetter wrote:
> > Everybody i've ever talked to who i felt confident knew more about ant
> > then me (with Erik at teh top of the list) has said the same thing:  
> > "Put
> > junit and ant-junit in your ANT_LIB ... don't even try to do anything
> > else, it will just burn you."
> 
> I'm not sure if that is still mandatory.  It used to be in the Ant  
> 1.5/.6 days, but I'm a bit out of practice with deep down Ant stuff  
> these days, so consider that advice dated at least and possibly no  
> longer applicable.

It is not!

You can put it in the lib home and ant will find junit. I have it in my
project. 

I am importing solr build scripts in my project and build it from my
project without problem because the junit.jar is in my classpath. As
soon I want to build solr directly I can't because the <fail ...> junit
check.

However one can place the junit lib into the lib dir and add it to the
classpath.

I can submit a patch tomorrow if you want.

> 
> 	Erik
> 
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Re: svn commit: r577427 - in /lucene/solr/trunk/client/java/solrj/test/org/apache/solr/client/solrj: LargeVolumeTestBase.java embedded/LargeVolumeEmbeddedTest.java embedded/LargeVolumeJettyTest.java

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Sun, 2007-09-23 at 22:51 -0700, Chris Hostetter wrote:
> : > I'm not sure which "lib home" you are talking about, but I'm certainly 
> : > open to a patch that allows us to bundle junit we want so new developers 
> : > don't have to get it themselves ... i tried doing this not too long ago 
> : > when i read that <taskdefs> could speficy classpaths for finding the task 
> : > -- it worked great forsome things (like PMD) but i couldn't get it to work 
> : > with ant to save my life.
> : 
> : done
> 
> It's times like this that i wish i could get away with using the 
> expression "Crikey!" without seeming compleltey phoney.
> 
> I was about to point out that all this patch does is include junit, and 
> doesn't solve the problem of the ant-junit.jar ... but then I realized 
> that going back at least as far as and 1.6.2, "ant-junit.jar" is included 
> with the ant release.  When i tried to solve this before, i assume i'd put 
> that ant-junit.jar in my ANT_LIB when i put junit.jar there -- and that to 
> do this right we'd need to bundle ant-junit.jar into solr as well (and 
> that's what i couldn't get to work).
> 
> now i really feel like an idiot.

jeje, do not be so hard on you! 

That is why a healthy community solves many problems very quick.  

salu2
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Re: svn commit: r577427 - in /lucene/solr/trunk/client/java/solrj/test/org/apache/solr/client/solrj: LargeVolumeTestBase.java embedded/LargeVolumeEmbeddedTest.java embedded/LargeVolumeJettyTest.java

Posted by Chris Hostetter <ho...@fucit.org>.
: > I'm not sure which "lib home" you are talking about, but I'm certainly 
: > open to a patch that allows us to bundle junit we want so new developers 
: > don't have to get it themselves ... i tried doing this not too long ago 
: > when i read that <taskdefs> could speficy classpaths for finding the task 
: > -- it worked great forsome things (like PMD) but i couldn't get it to work 
: > with ant to save my life.
: 
: done

It's times like this that i wish i could get away with using the 
expression "Crikey!" without seeming compleltey phoney.

I was about to point out that all this patch does is include junit, and 
doesn't solve the problem of the ant-junit.jar ... but then I realized 
that going back at least as far as and 1.6.2, "ant-junit.jar" is included 
with the ant release.  When i tried to solve this before, i assume i'd put 
that ant-junit.jar in my ANT_LIB when i put junit.jar there -- and that to 
do this right we'd need to bundle ant-junit.jar into solr as well (and 
that's what i couldn't get to work).

now i really feel like an idiot.





-Hoss


Re: svn commit: r577427 - in /lucene/solr/trunk/client/java/solrj/test/org/apache/solr/client/solrj: LargeVolumeTestBase.java embedded/LargeVolumeEmbeddedTest.java embedded/LargeVolumeJettyTest.java

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Thu, 2007-09-20 at 11:11 -0700, Chris Hostetter wrote:
> : You can put it in the lib home and ant will find junit. I have it in my
> : project. 
> 
> : I can submit a patch tomorrow if you want.
> 
> I'm not sure which "lib home" you are talking about, but I'm certainly 
> open to a patch that allows us to bundle junit we want so new developers 
> don't have to get it themselves ... i tried doing this not too long ago 
> when i read that <taskdefs> could speficy classpaths for finding the task 
> -- it worked great forsome things (like PMD) but i couldn't get it to work 
> with ant to save my life.

done

https://issues.apache.org/jira/browse/SOLR-362

salu2

> 
> 
> : I am importing solr build scripts in my project and build it from my
> : project without problem because the junit.jar is in my classpath. As
> : soon I want to build solr directly I can't because the <fail ...> junit
> : check.
> 
> (Note: even if we can't get a patch working that does this, this specific 
> problem is easy to deal with: even if junit isn't in your ANT_LIB, you can 
> always use ant's -lib option to do this too.)
> 
> 
> -Hoss
> 
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Re: svn commit: r577427 - in /lucene/solr/trunk/client/java/solrj/test/org/apache/solr/client/solrj: LargeVolumeTestBase.java embedded/LargeVolumeEmbeddedTest.java embedded/LargeVolumeJettyTest.java

Posted by Chris Hostetter <ho...@fucit.org>.
: You can put it in the lib home and ant will find junit. I have it in my
: project. 

: I can submit a patch tomorrow if you want.

I'm not sure which "lib home" you are talking about, but I'm certainly 
open to a patch that allows us to bundle junit we want so new developers 
don't have to get it themselves ... i tried doing this not too long ago 
when i read that <taskdefs> could speficy classpaths for finding the task 
-- it worked great forsome things (like PMD) but i couldn't get it to work 
with ant to save my life.


: I am importing solr build scripts in my project and build it from my
: project without problem because the junit.jar is in my classpath. As
: soon I want to build solr directly I can't because the <fail ...> junit
: check.

(Note: even if we can't get a patch working that does this, this specific 
problem is easy to deal with: even if junit isn't in your ANT_LIB, you can 
always use ant's -lib option to do this too.)


-Hoss