[GitHub] [incubator-yunikorn-core] anuraagnalluri commented on a change in pull request #365: [YUNIKORN-949] Location of the state dump file should be configurable

[GitBox <gi...@apache.org>]

anuraagnalluri commented on a change in pull request #365:
URL: https://github.com/apache/incubator-yunikorn-core/pull/365#discussion_r791380193



##########
File path: pkg/webservice/state_dump.go
##########
@@ -157,7 +160,20 @@ func doStateDump(w io.Writer) error {
 	if err != nil {
 		return err
 	}
-	if _, err = w.Write(prettyJSON); err != nil {
+
+	stateLog := log.New(w, "", 0)

Review comment:
       Good point -- this may be wasteful. However, the log object requires being constructed from the response writer which is why I had it in this method. I'll familiarize myself more with how the response writer gets passed from `routes.go` and see if I can change this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org