You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by nakomis <gi...@git.apache.org> on 2014/10/31 13:20:42 UTC
[GitHub] incubator-brooklyn pull request: Fix/dependent configuration run n...
GitHub user nakomis opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/287
Fix/dependent configuration run now
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nakomis/incubator-brooklyn fix/dependent-configuration-run-now
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/287.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #287
----
commit c599d760c158ec4fbe0c861314e6d38dec8ae88e
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-10-31T12:12:12Z
Adds failing test for DependentConfiguration.builder()..runNow()
commit 95fc839ae2062a0c1cc3d67483b9bf2d393d7e85
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-10-31T12:20:03Z
Fixes DependentConfiguration.builder()...runNow()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix/dependent configuration run n...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/287#issuecomment-61253626
Fix looks good. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix/dependent configuration run n...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/287
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix/dependent configuration run n...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/287#discussion_r19663972
--- Diff: core/src/test/java/brooklyn/entity/basic/DependentConfigurationTest.java ---
@@ -255,6 +255,21 @@ public String call() {
}
@Test
+ public void testAttributeWhenReadyRunNowWithoutPostProcess() throws Exception {
+ Task<String> t = submit(new Callable<String>() {
+ @Override
+ public String call() throws Exception {
+ return DependentConfiguration.builder()
+ .attributeWhenReady(entity, TestEntity.NAME)
+ .runNow();
+ }
+ });
+ entity.setAttribute(TestEntity.NAME, "myentity");
+ assertDoneEventually(t);
--- End diff --
For future reference , could use `assertEquals(assertDoneEventually(t), "myentity")`.
But your code is absolutely fine as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---