You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "shreemaan-abhishek (via GitHub)" <gi...@apache.org> on 2026/03/04 05:34:44 UTC
[PR] fix: avoid initialising stream plugins in http subsystem [apisix]
shreemaan-abhishek opened a new pull request, #13064:
URL: https://github.com/apache/apisix/pull/13064
### Description
Fixes #12458
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: avoid initialising stream plugins in http subsystem [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on code in PR #13064:
URL: https://github.com/apache/apisix/pull/13064#discussion_r2882077865
##########
apisix/plugin.lua:
##########
@@ -197,6 +197,13 @@ local function load_plugin(name, plugins_list, plugin_type)
plugin.attr = plugin_attr(name)
core.table.insert(plugins_list, plugin)
+ -- Don't initialize stream plugins in the HTTP subsystem.
+ -- The modules are loaded for schema validation (admin API),
+ -- but init/workflow_handler functions must only run in the stream subsystem.
+ if plugin_type == PLUGIN_TYPE_STREAM and is_http then
+ return
Review Comment:
Will the stream plugin be destroyed in the HTTP subsystem? If so, the `destroy()` function is called, but `init()` is skipped. Is there a potential issue of lifecycle asymmetry?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: avoid initialising stream plugins in http subsystem [apisix]
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on code in PR #13064:
URL: https://github.com/apache/apisix/pull/13064#discussion_r2882245642
##########
apisix/plugin.lua:
##########
@@ -197,6 +197,13 @@ local function load_plugin(name, plugins_list, plugin_type)
plugin.attr = plugin_attr(name)
core.table.insert(plugins_list, plugin)
+ -- Don't initialize stream plugins in the HTTP subsystem.
+ -- The modules are loaded for schema validation (admin API),
+ -- but init/workflow_handler functions must only run in the stream subsystem.
+ if plugin_type == PLUGIN_TYPE_STREAM and is_http then
+ return
Review Comment:
such a great catch, I have fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: avoid initialising stream plugins in http subsystem [apisix]
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek merged PR #13064:
URL: https://github.com/apache/apisix/pull/13064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org