[GitHub] [incubator-pegasus] GehaFearless commented on a diff in pull request #1091: feat: improve performance of count_data

[GitBox <gi...@apache.org>]

GehaFearless commented on code in PR #1091:
URL: https://github.com/apache/incubator-pegasus/pull/1091#discussion_r938593714


##########
src/shell/commands/data_operations.cpp:
##########
@@ -2397,6 +2401,15 @@ bool count_data(command_executor *e, shell_context *sc, arguments args)
         options.no_value = false;
     else
         options.no_value = true;
+
+    if (diff_hash_key || stat_size || value_filter_type != pegasus::pegasus_client::FT_NO_FILTER ||

Review Comment:
   I will make another one pull request laster.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org