You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by "Bill Havanki (JIRA)" <ji...@apache.org> on 2014/01/13 18:38:53 UTC

[jira] [Commented] (ACCUMULO-2039) Authorizations.getAuthorizationsBB is inefficient

    [ https://issues.apache.org/jira/browse/ACCUMULO-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13869728#comment-13869728 ] 

Bill Havanki commented on ACCUMULO-2039:
----------------------------------------

The patch looks fine.

One question for other committers: The patch eliminates a public method in ByteBufferUtil, since it was only used by the code being changed and could be refactored away. Is that elimination OK?

> Authorizations.getAuthorizationsBB is inefficient
> -------------------------------------------------
>
>                 Key: ACCUMULO-2039
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2039
>             Project: Accumulo
>          Issue Type: Improvement
>    Affects Versions: 1.6.0
>            Reporter: Bill Havanki
>            Assignee: Vikram Srivastava
>            Priority: Trivial
>              Labels: PatchAvailable
>         Attachments: ACCUMULO-2039.v1.patch.txt
>
>
> Authorizations.getAuthorizations was reworked for 1.6.0 to build an immutable list of copies of contained authorizations. The Authorizations.getAuthorizationsBB method then takes that list and makes another immutable list of copies. The latter method could be made much more efficient by eliminating the extra copies and (possibly) list construction.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)