[GitHub] [tinkerpop] spmallette edited a comment on pull request #1479: TINKERPOP-2616: Provide better exceptions with SSL related failures

[GitBox <gi...@apache.org>]

spmallette edited a comment on pull request #1479:
URL: https://github.com/apache/tinkerpop/pull/1479#issuecomment-934437007


   @simonz-bq i've merged this - here's some additional points:
   
   1. `master` failed on this test `shouldEnableSslAndFailIfProtocolsDontMatch` - something is different there where we don't get an `SSLException` there but a `ClosedChannelException`. I'm not sure why but i changed the behavior temporarily ( e7c889967a5c40de6e4d5086e8e7d547ba6f406b ) Could you please investigate that and see if we can get `SSLException` there so that behavior can remain consistent? 
   2. now that this is merged, could you backport the change in a non-breaking way as @divijvaidya suggested? i suppose that means, retaining the old exception contract but pushing `SSLException` into the "cause". if you think there is something particularly hard in doing that please let us know. we're in the "very minor enhancements and bug fixes only" phase of 3.4-dev so if it's anything terribly complicated perhaps we can just count it out of scope.
   
   You can just submit whatever fix PRs are necessary on this JIRA issue. Taken together, that should close this one out.
   
   *UPDATE* - it seems that error from item 1 was actually also failing on 3.5-dev so it seems you should target that branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org