You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by benoitdevos <gi...@git.apache.org> on 2018/10/25 15:36:00 UTC
[GitHub] qpid-jms pull request #23: onConnectionEstablished(): log only main broker U...
GitHub user benoitdevos opened a pull request:
https://github.com/apache/qpid-jms/pull/23
onConnectionEstablished(): log only main broker URI part.
This commit changes a little bit the logging info in the onConnectionEstablished() method. URI query params do not need to be logged.
**Context**
The broker URI may contain sensitive info (like path to trust / key stores, and related **passwords**), and this info is being logged.
_Sample_:
```
<bean id="jmsConnectionFactory" class="org.apache.qpid.jms.JmsConnectionFactory">
<constructor-arg name="remoteURI" value="amqps://some-location:5671?
transport.keyStoreLocation=/very/long/path/nnn-openssl.p12&
transport.keyStorePassword=*******&
transport.trustStoreLocation=/very/long/path/server.keystore&
transport.trustStorePassword=*******"/>
</bean>
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benoitdevos/qpid-jms master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-jms/pull/23.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23
----
commit ec2559906880ba1369a15b92b00c3d5482166a00
Author: Benoit Devos <be...@...>
Date: 2018-10-25T15:25:01Z
onConnectionEstablished(): log only main broker URI part.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-jms issue #23: onConnectionEstablished(): log only main broker URI part...
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:
https://github.com/apache/qpid-jms/pull/23
You should open a new JIRA to track this and use the JIRA entry in the commit title in order to link the two. Refer to the commits in the log already for a proper example.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-jms issue #23: onConnectionEstablished(): log only main broker URI part...
Posted by benoitdevos <gi...@git.apache.org>.
Github user benoitdevos commented on the issue:
https://github.com/apache/qpid-jms/pull/23
OK for the JIRA issue. Any idea why the build is failing ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-jms issue #23: QPIDJMS-423 onConnectionEstablished(): log only main bro...
Posted by benoitdevos <gi...@git.apache.org>.
Github user benoitdevos commented on the issue:
https://github.com/apache/qpid-jms/pull/23
@tabish121 I created [QPIDJMS-423](https://issues.apache.org/jira/browse/QPIDJMS-423) and changed the commit message.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-jms issue #23: onConnectionEstablished(): log only main broker URI part...
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:
https://github.com/apache/qpid-jms/pull/23
Possible race in the test, seems unrelated
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-jms pull request #23: QPIDJMS-423 onConnectionEstablished(): log only m...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-jms/pull/23
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org