You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/03/14 20:53:30 UTC
[GitHub] [incubator-druid] jihoonson edited a comment on issue #7267: Logic
adjustments to SeekableStreamIndexTaskRunner.
jihoonson edited a comment on issue #7267: Logic adjustments to SeekableStreamIndexTaskRunner.
URL: https://github.com/apache/incubator-druid/pull/7267#issuecomment-473053998
I meant, there are people who prefer `sequence` and `stream`. I also think `offset` and `topic` are better terms for internal usage. But it was decided to use `sequence` and `stream` in #6431 because the authors think they are better. If you think we should change it, I think we should discuss it with other people including original authors. I personally prefer to not change in this PR to not block 0.14 release anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org