You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by Thijs <vo...@gmail.com> on 2009/04/01 14:42:26 UTC
Re: Should a form submit when sub-form has error's?
If you are referring to
org.apache.wicket.markup.html.form.validation.TestHomePage
Those never run at least not when I call "mvn clean package"
I had to change it to
org.apache.wicket.markup.html.form.validation.HomePageTest to get it to
work. (Which in my view could indicate that there are more tests not
running)
still checking the actual problem.
Thijs
On 31-3-2009 19:51, Igor Vaynberg wrote:
> not it shouldnt. there should already be unit tests that check for
> this, can you please check those and provide a patch if possible.
>
> -igor
>
> On Tue, Mar 31, 2009 at 4:34 AM, Thijs<vo...@gmail.com> wrote:
>
>> Hi,
>>
>> Should a Form submit when a subform has error's?
>>
>> I have a main-form where I add a panel that contains another form.
>> This sub-form contains a formvalidator that gives the error.
>> However the main-form is submitted, but the feedbackpanel does show the
>> error message set in the sub-form's validator.
>>
>> Is this expected behavior using 1.4-snapshot?
>>
>> Because in wicket 1.3.x this does work and the mainform is not submitted.
>> (I can provide a testcase if needed)
>>
>>
>> Thijs
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
Re: Should a form submit when sub-form has error's?
Posted by Thijs <vo...@gmail.com>.
Created https://issues.apache.org/jira/browse/WICKET-2202 with a patch
containing testcases to display the error.
No fix as of yet.
On 1-4-2009 14:42, Thijs wrote:
> If you are referring to
> org.apache.wicket.markup.html.form.validation.TestHomePage
> Those never run at least not when I call "mvn clean package"
> I had to change it to
> org.apache.wicket.markup.html.form.validation.HomePageTest to get it
> to work. (Which in my view could indicate that there are more tests
> not running)
>
> still checking the actual problem.
>
> Thijs
>
> On 31-3-2009 19:51, Igor Vaynberg wrote:
>> not it shouldnt. there should already be unit tests that check for
>> this, can you please check those and provide a patch if possible.
>>
>> -igor
>>
>> On Tue, Mar 31, 2009 at 4:34 AM, Thijs<vo...@gmail.com> wrote:
>>
>>> Hi,
>>>
>>> Should a Form submit when a subform has error's?
>>>
>>> I have a main-form where I add a panel that contains another form.
>>> This sub-form contains a formvalidator that gives the error.
>>> However the main-form is submitted, but the feedbackpanel does show the
>>> error message set in the sub-form's validator.
>>>
>>> Is this expected behavior using 1.4-snapshot?
>>>
>>> Because in wicket 1.3.x this does work and the mainform is not submitted.
>>> (I can provide a testcase if needed)
>>>
>>>
>>> Thijs
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail:users-unsubscribe@wicket.apache.org
>>> For additional commands, e-mail:users-help@wicket.apache.org
>>>
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail:users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail:users-help@wicket.apache.org
>>
>>
>