You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/03 13:24:51 UTC

[GitHub] [arrow] lidavidm commented on a change in pull request #10224: ARROW-12631: [Python] Accept Scanner in pyarrow.dataset.write_dataset

lidavidm commented on a change in pull request #10224:
URL: https://github.com/apache/arrow/pull/10224#discussion_r625082780



##########
File path: python/pyarrow/dataset.py
##########
@@ -733,19 +733,17 @@ def write_dataset(data, base_dir, basename_template=None, format=None,
     """
     from pyarrow.fs import _resolve_filesystem_and_path
 
-    if isinstance(data, Dataset):
-        schema = schema or data.schema

Review comment:
       Hmm, would the user ever want to pass a schema to force a cast? Though I suppose that's redundant (either configure the scanner or pass a scanner instead of a dataset).
   
   I think a deprecation warning would be appropriate here (schema will only be allowed when passing an iterable in the future).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org