[jira] [Closed] (TINKERPOP-1812) ProfileTest assumes that graph implementations will not add their own steps

["stephen mallette (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TINKERPOP-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stephen mallette closed TINKERPOP-1812.
---------------------------------------
       Resolution: Done
         Assignee: stephen mallette
    Fix Version/s: 3.3.1
                   3.2.7

I did most of this work a long time ago. I had just missed a couple of assertions in the tests mentioned here:

https://github.com/apache/tinkerpop/commit/7d20981872bd0adc769afe86c47f5f3178de7f6e

> ProfileTest assumes that graph implementations will not add their own steps
> ---------------------------------------------------------------------------
>
>                 Key: TINKERPOP-1812
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1812
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.2.6
>            Reporter: Bryn Cooke
>            Assignee: stephen mallette
>             Fix For: 3.2.7, 3.3.1
>
>
> The following two tests check the number of steps in the traversal:
> g_V_sideEffectXThread_sleepX10XX_sideEffectXThread_sleepX5XX_profileXmetricsX
> g_V_sideEffectXThread_sleepX10XX_sideEffectXThread_sleepX5XX_profile
> This assumes that graph implementations add no steps to the traversal. They should probably be checking the structure of the traversal rather than the total number of steps. For instance that each step is followed by a profile step and that the profile side effect step and cap step are the last steps.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)