You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "tbw777 (via GitHub)" <gi...@apache.org> on 2023/02/10 08:49:21 UTC
[GitHub] [netbeans] tbw777 opened a new pull request, #5463: Re
tbw777 opened a new pull request, #5463:
URL: https://github.com/apache/netbeans/pull/5463
java + xsd (separate commits)
Changes:
- [a-zA-Z0-9_] -> \w
- [0-9] -> \d
- [^\s] -> \S
- removed unnessasary escaping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #5463: Patterns normalization
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #5463:
URL: https://github.com/apache/netbeans/pull/5463#issuecomment-1426084036
From the examples in the description I don't see a real benefit. Replacing explicit character groups with their symbol does not help readability or at least it highly depends on the location. A quick look at the code changes supports this. From a review perspective this a nightmare and from a benefit perspective I don't see it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #5463: Patterns normalization
Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi commented on PR #5463:
URL: https://github.com/apache/netbeans/pull/5463#issuecomment-1426615163
@tbw777 I've got a bit curious. Why are you doing these? What's your purpose with these kind of PRs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 closed pull request #5463: Patterns normalization
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 closed pull request #5463: Patterns normalization
URL: https://github.com/apache/netbeans/pull/5463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5463: Patterns normalization
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5463:
URL: https://github.com/apache/netbeans/pull/5463#issuecomment-1426147829
[8684e80](https://github.com/apache/netbeans/pull/5463/commits/8684e80daf35224eb23b0d420946196d84f0dc40)
Can we use this commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #5463: Patterns normalization
Posted by "BradWalker (via GitHub)" <gi...@apache.org>.
BradWalker commented on PR #5463:
URL: https://github.com/apache/netbeans/pull/5463#issuecomment-1425856587
I have to say that regular expressions is definitely not my strong point. So I'm not inclined to review this, even if it is easy. Especially since a change, even if it is considered "simple" could possibly introduce a change in behavior.
Again, if it were me, I would say to myself: "Self, do we have a problem here or are we changing this just to be technically pure?"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5463: Patterns normalization
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5463:
URL: https://github.com/apache/netbeans/pull/5463#issuecomment-1425867598
at your discretion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists