[GitHub] tinkerpop pull request #922: TINKERPOP-1959: Gremlin Javascript ability to s...

[jorgebay <gi...@git.apache.org>]

Github user jorgebay commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/922#discussion_r214822151
  
    --- Diff: gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/client.js ---
    @@ -0,0 +1,65 @@
    +/*
    + *  Licensed to the Apache Software Foundation (ASF) under one
    + *  or more contributor license agreements.  See the NOTICE file
    + *  distributed with this work for additional information
    + *  regarding copyright ownership.  The ASF licenses this file
    + *  to you under the Apache License, Version 2.0 (the
    + *  "License"); you may not use this file except in compliance
    + *  with the License.  You may obtain a copy of the License at
    + *
    + *  http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *  Unless required by applicable law or agreed to in writing,
    + *  software distributed under the License is distributed on an
    + *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + *  KIND, either express or implied.  See the License for the
    + *  specific language governing permissions and limitations
    + *  under the License.
    + */
    +'use strict';
    +
    +const DriverRemoteConnection = require('./driver-remote-connection');
    +const Bytecode = require('../process/bytecode');
    +
    +class Client extends DriverRemoteConnection {
    --- End diff --
    
    `Client` should not extend `DriverRemoteConnection`, as in the other GLVs `Client` should contain and manage the lifetime of `DriverRemoteConnection` instances, ie: expose `open()` and `shutdown()` methods that open and close the connections that belong to the `DriverRemoteConnection`.



---