You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@avro.apache.org by "Kalle Niemitalo (Jira)" <ji...@apache.org> on 2022/06/30 12:52:00 UTC

[jira] [Commented] (AVRO-2774) missing @Override annotations in generated code

    [ https://issues.apache.org/jira/browse/AVRO-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561030#comment-17561030 ] 

Kalle Niemitalo commented on AVRO-2774:
---------------------------------------

In [https://github.com/apache/avro/pull/1721], there is some test code that uses {{&#64;SuppressWarnings("all")}} to suppress CodeQL warnings about missing Override annotations. After the code generator is changed to add the Override annotations as requested in this issue, the test code should be regenerated and the SuppressWarnings annotations should be removed.

> missing @Override annotations in generated code
> -----------------------------------------------
>
>                 Key: AVRO-2774
>                 URL: https://issues.apache.org/jira/browse/AVRO-2774
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.9.1, 1.9.2
>         Environment: openjdk version "11.0.6" 2020-01-14 LTS
> avro 1.9.2
> gradle avro plugin
>            Reporter: Tim Spriggs
>            Priority: Major
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When applying errorProne to my project, I get errors from the MissingOverride rule. eg:
> error: [MissingOverride] getSpecificData overrides method in SpecificRecordBase
> error: [MissingOverride] getSchema implements method in SpecificRecordBase
> error: [MissingOverride] get implements method in SpecificRecordBase
> error: [MissingOverride] put implements method in SpecificRecordBase
>  
> If these are always tagged with @Override then static analysis and IDE hints perform better.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)