You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/25 10:19:40 UTC

[GitHub] [shardingsphere] chenxk opened a new pull request #10458: Fix the bug 'Exceeded the maximum number of open cursors'

chenxk opened a new pull request #10458:
URL: https://github.com/apache/shardingsphere/pull/10458


   Issues :10449
   
   Fixes #ISSUSE_ID.
   
   Changes proposed in this pull request:
   - Extract: Statement statement = connection.createStatement();
   - Add  close operation :  statement .close.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu closed pull request #10458: Fix the bug 'Exceeded the maximum number of open cursors'

Posted by GitBox <gi...@apache.org>.
strongduanmu closed pull request #10458:
URL: https://github.com/apache/shardingsphere/pull/10458


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] chenxk closed pull request #10458: Fix the bug 'Exceeded the maximum number of open cursors'

Posted by GitBox <gi...@apache.org>.
chenxk closed pull request #10458:
URL: https://github.com/apache/shardingsphere/pull/10458


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on pull request #10458: Fix the bug 'Exceeded the maximum number of open cursors'

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #10458:
URL: https://github.com/apache/shardingsphere/pull/10458#issuecomment-849208617


   Duplicate with #10471.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #10458: Fix the bug 'Exceeded the maximum number of open cursors'

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #10458:
URL: https://github.com/apache/shardingsphere/pull/10458#discussion_r639338859



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/schema/builder/loader/ColumnMetaDataLoader.java
##########
@@ -37,21 +38,21 @@
  */
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
 public final class ColumnMetaDataLoader {
-    
+
     private static final String COLUMN_NAME = "COLUMN_NAME";
-    
+
     private static final String DATA_TYPE = "DATA_TYPE";
-    
+
     private static final String TYPE_NAME = "TYPE_NAME";
-    
+
     private static final String TABLE_NAME = "TABLE_NAME";
-    
+
     /**
      * Load column meta data list.
-     * 
-     * @param connection connection
+     *
+     * @param connection       connection

Review comment:
       @chenxk Please refer the doc of [Code of Conduct](https://shardingsphere.apache.org/community/en/contribute/code-conduct/), and execute checkstyle first.

##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/schema/builder/loader/ColumnMetaDataLoader.java
##########
@@ -37,21 +38,21 @@
  */
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
 public final class ColumnMetaDataLoader {
-    
+
     private static final String COLUMN_NAME = "COLUMN_NAME";
-    
+
     private static final String DATA_TYPE = "DATA_TYPE";
-    
+
     private static final String TYPE_NAME = "TYPE_NAME";
-    
+
     private static final String TABLE_NAME = "TABLE_NAME";
-    

Review comment:
       @chenxk Please keep indents consistent with the previous one.

##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/schema/builder/loader/ColumnMetaDataLoader.java
##########
@@ -75,22 +76,24 @@
                 }
             }
         }
-        try (ResultSet resultSet = connection.createStatement().executeQuery(generateEmptyResultSQL(tableNamePattern, databaseType))) {
+        Statement statement = connection.createStatement();
+        try (ResultSet resultSet = statement.executeQuery(generateEmptyResultSQL(tableNamePattern, databaseType))) {

Review comment:
       @chenxk 
   This style may be better.
   ```java
   try (Statement statement = connection.createStatement(); ResultSet resultSet = statement.executeQuery(generateEmptyResultSQL(tableNamePattern, databaseType))) {
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on pull request #10458: Fix the bug 'Exceeded the maximum number of open cursors'

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #10458:
URL: https://github.com/apache/shardingsphere/pull/10458#issuecomment-848389519


   > Issues :10449
   > 
   > Fixes #ISSUSE_ID.
   > 
   > Changes proposed in this pull request:
   > 
   > * Extract: Statement statement = connection.createStatement();
   > * Add  close operation :  statement .close.
   
   @chenxk Please change it to `Fixes #10449`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #10458: Fix the bug 'Exceeded the maximum number of open cursors'

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10458:
URL: https://github.com/apache/shardingsphere/pull/10458#issuecomment-848397228


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#10458](https://codecov.io/gh/apache/shardingsphere/pull/10458?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a063dba) into [master](https://codecov.io/gh/apache/shardingsphere/commit/c6383f11390bbeeca79d263ac3f8a506fd4d8d93?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c6383f1) will **decrease** coverage by `0.12%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/10458/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/10458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #10458      +/-   ##
   ============================================
   - Coverage     68.59%   68.46%   -0.13%     
     Complexity      702      702              
   ============================================
     Files          1750     1758       +8     
     Lines         29868    30009     +141     
     Branches       5348     5376      +28     
   ============================================
   + Hits          20487    20545      +58     
   - Misses         7822     7891      +69     
   - Partials       1559     1573      +14     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/10458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ta/schema/builder/loader/ColumnMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/10458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9zY2hlbWEvYnVpbGRlci9sb2FkZXIvQ29sdW1uTWV0YURhdGFMb2FkZXIuamF2YQ==) | `88.57% <100.00%> (+0.69%)` | :arrow_up: |
   | [.../transaction/TransactionBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/10458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L3RyYW5zYWN0aW9uL1RyYW5zYWN0aW9uQmFja2VuZEhhbmRsZXJGYWN0b3J5LmphdmE=) | `64.70% <0.00%> (-35.30%)` | :arrow_down: |
   | [...service/config/impl/GlobalRuleRegistryService.java](https://codecov.io/gh/apache/shardingsphere/pull/10458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9zZXJ2aWNlL2NvbmZpZy9pbXBsL0dsb2JhbFJ1bGVSZWdpc3RyeVNlcnZpY2UuamF2YQ==) | `15.15% <0.00%> (-30.31%)` | :arrow_down: |
   | [...nd/text/transaction/TransactionBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/10458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L3RyYW5zYWN0aW9uL1RyYW5zYWN0aW9uQmFja2VuZEhhbmRsZXIuamF2YQ==) | `45.00% <0.00%> (-19.29%)` | :arrow_down: |
   | [...tion/jdbc/transaction/LocalTransactionManager.java](https://codecov.io/gh/apache/shardingsphere/pull/10458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvdHJhbnNhY3Rpb24vTG9jYWxUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `3.12% <0.00%> (-10.77%)` | :arrow_down: |
   | [...atement/impl/PostgreSQLTCLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/10458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9zdGF0ZW1lbnQvaW1wbC9Qb3N0Z3JlU1FMVENMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `71.42% <0.00%> (-8.58%)` | :arrow_down: |
   | [...end/text/distsql/rql/RQLBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/10458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcnFsL1JRTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `20.00% <0.00%> (-7.28%)` | :arrow_down: |
   | [...on/jdbc/transaction/BackendTransactionManager.java](https://codecov.io/gh/apache/shardingsphere/pull/10458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvdHJhbnNhY3Rpb24vQmFja2VuZFRyYW5zYWN0aW9uTWFuYWdlci5qYXZh) | `86.95% <0.00%> (-3.37%)` | :arrow_down: |
   | [...dingsphere/distsql/parser/core/DistSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/10458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL0Rpc3RTUUxWaXNpdG9yLmphdmE=) | `88.88% <0.00%> (-0.52%)` | :arrow_down: |
   | [...sphere/sql/parser/core/visitor/SQLVisitorRule.java](https://codecov.io/gh/apache/shardingsphere/pull/10458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL3Zpc2l0b3IvU1FMVmlzaXRvclJ1bGUuamF2YQ==) | `100.00% <0.00%> (ø)` | |
   | ... and [15 more](https://codecov.io/gh/apache/shardingsphere/pull/10458/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10458?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10458?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c6383f1...a063dba](https://codecov.io/gh/apache/shardingsphere/pull/10458?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org