You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2018/06/05 05:57:35 UTC
pending PR@github
Hi guys,
spent some time reviewing our PRs on github (OWB+MW), think all have an up
to date comment if needed (some are missing headers, one was introducing a
bug, others were mainly good).
I'm not sure why i missed them on the list but some are old and should pby
be better at merging them.
If anyone has some free time to do another pass and potentially merge a few
(@reta one for instance is ready to merge) it can be very good too.
I'll try to do another one if comments are fixed end of the week to try to
merge a few.
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Re: pending PR@github
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Seems 2 last weeks (https://github.com/apache/meecrowave/pulls)
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Le mar. 5 juin 2018 à 08:44, Mark Struberg <st...@yahoo.de.invalid> a
écrit :
> Or was there some new PR in the last 3 weeks?
>
> LieGrue,
> strub
>
> > Am 05.06.2018 um 08:43 schrieb Mark Struberg <st...@yahoo.de>:
> >
> > I also think I've gone through most of them and back then all got
> applied or didn't cut it.
> > I simply have no way to close them though...
> >
> > LieGrue,
> > strub
> >
> >
> >> Am 05.06.2018 um 07:57 schrieb Romain Manni-Bucau <
> rmannibucau@gmail.com>:
> >>
> >> Hi guys,
> >>
> >> spent some time reviewing our PRs on github (OWB+MW), think all have an
> up
> >> to date comment if needed (some are missing headers, one was
> introducing a
> >> bug, others were mainly good).
> >>
> >> I'm not sure why i missed them on the list but some are old and should
> pby
> >> be better at merging them.
> >>
> >> If anyone has some free time to do another pass and potentially merge a
> few
> >> (@reta one for instance is ready to merge) it can be very good too.
> >> I'll try to do another one if comments are fixed end of the week to try
> to
> >> merge a few.
> >>
> >> Romain Manni-Bucau
> >> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> >> <https://rmannibucau.metawerx.net/> | Old Blog
> >> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> >> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> >> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
> >
>
>
Re: pending PR@github
Posted by Mark Struberg <st...@yahoo.de.INVALID>.
Or was there some new PR in the last 3 weeks?
LieGrue,
strub
> Am 05.06.2018 um 08:43 schrieb Mark Struberg <st...@yahoo.de>:
>
> I also think I've gone through most of them and back then all got applied or didn't cut it.
> I simply have no way to close them though...
>
> LieGrue,
> strub
>
>
>> Am 05.06.2018 um 07:57 schrieb Romain Manni-Bucau <rm...@gmail.com>:
>>
>> Hi guys,
>>
>> spent some time reviewing our PRs on github (OWB+MW), think all have an up
>> to date comment if needed (some are missing headers, one was introducing a
>> bug, others were mainly good).
>>
>> I'm not sure why i missed them on the list but some are old and should pby
>> be better at merging them.
>>
>> If anyone has some free time to do another pass and potentially merge a few
>> (@reta one for instance is ready to merge) it can be very good too.
>> I'll try to do another one if comments are fixed end of the week to try to
>> merge a few.
>>
>> Romain Manni-Bucau
>> @rmannibucau <https://twitter.com/rmannibucau> | Blog
>> <https://rmannibucau.metawerx.net/> | Old Blog
>> <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
>> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>
Re: pending PR@github
Posted by Mark Struberg <st...@yahoo.de.INVALID>.
I also think I've gone through most of them and back then all got applied or didn't cut it.
I simply have no way to close them though...
LieGrue,
strub
> Am 05.06.2018 um 07:57 schrieb Romain Manni-Bucau <rm...@gmail.com>:
>
> Hi guys,
>
> spent some time reviewing our PRs on github (OWB+MW), think all have an up
> to date comment if needed (some are missing headers, one was introducing a
> bug, others were mainly good).
>
> I'm not sure why i missed them on the list but some are old and should pby
> be better at merging them.
>
> If anyone has some free time to do another pass and potentially merge a few
> (@reta one for instance is ready to merge) it can be very good too.
> I'll try to do another one if comments are fixed end of the week to try to
> merge a few.
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <https://www.packtpub.com/application-development/java-ee-8-high-performance>