You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2026/04/28 22:18:48 UTC

[PR] Add review rule for shared integration test clusters [pinot]

xiangfu0 opened a new pull request, #18362:
URL: https://github.com/apache/pinot/pull/18362

   ## Summary
   - add a C6.10 testing principle that rejects standalone Pinot integration-test clusters when no special setup is required
   - tighten the `review-testing` skill so it suggests reusing an existing `CustomDataQueryClusterIntegrationTest` or adding a focused custom-suite subclass
   - document the expected custom-suite annotation and suite XML path
   
   ## Reviewer manual
   When a PR adds a Pinot integration test that only needs custom schema, data, and SQL assertions, the review agent should flag a fresh `BaseClusterIntegrationTest` or dedicated cluster setup as `MAJOR / C6.10`. The suggested fix is to reuse an existing custom-suite test or add a class under:
   
   `pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/`
   
   The new test should be part of the shared custom suite:
   
   ```java
   @Test(suiteName = "CustomClusterIntegrationTest")
   public class JsonFunctionTest extends CustomDataQueryClusterIntegrationTest {
     // define schema, data, and query assertions here
   }
   ```
   
   A standalone cluster remains acceptable when the test needs distinct topology, non-default component config, Helix/ZK layout, realtime wiring not covered by the custom base, or restart/lifecycle behavior.
   
   ## Testing
   - `git diff --check`
   
   No Maven run: this is review-agent documentation only.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Add review rule for shared integration test clusters [pinot]

Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #18362:
URL: https://github.com/apache/pinot/pull/18362


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org