You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wu-sheng (via GitHub)" <gi...@apache.org> on 2026/01/07 02:18:38 UTC
[I] [Feature] [BanyanDB] Support ID generation during writing in measure module [skywalking]
wu-sheng opened a new issue, #13656:
URL: https://github.com/apache/skywalking/issues/13656
### Search before asking
- [x] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
We found an issue in browser logs, which have duplicated UUID due to the limitation of the browser.
BanyanDB removed duplicated ones as the UUID issue. We should not trust the ID from logs in the database, as Measure module doesn't support update, we should generate an internal ID the writing process.
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a pull request to implement this on your own?
- [ ] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [x] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] [BanyanDB] Support ID generation during writing in measure module [skywalking]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on issue #13656:
URL: https://github.com/apache/skywalking/issues/13656#issuecomment-3721390207
> Hey Should I resolve this issue and yup it does required by reviewers with write access to do the changes.
Absolutely! Could you research and design the algorithm for ID generation? It should prioritize high performance. Once we all agree on the solution, you can proceed with the implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] [BanyanDB] Support ID generation during writing in measure module [skywalking]
Posted by "paultanay (via GitHub)" <gi...@apache.org>.
paultanay commented on issue #13656:
URL: https://github.com/apache/skywalking/issues/13656#issuecomment-3985340731
Should ID generation apply to all measures, or only append-only ones?
When two data points have the same seriesID + timestamp but different generated IDs, should the merger keep both (append mode), or still dedup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] [BanyanDB] Support ID generation during writing in measure module [skywalking]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily closed issue #13656: [Feature] [BanyanDB] Support ID generation during writing in measure module
URL: https://github.com/apache/skywalking/issues/13656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] [BanyanDB] Support ID generation during writing in measure module [skywalking]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on issue #13656:
URL: https://github.com/apache/skywalking/issues/13656#issuecomment-3987817776
> Should ID generation apply to all measures, or only append-only ones? When two data points have the same seriesID + timestamp but different generated IDs, should the merger keep both (append mode), or still dedup?
This applies only to streams, not measures. Streams have a relative logic that handles deduplication by element ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] [BanyanDB] Support ID generation during writing in measure module [skywalking]
Posted by "paultanay (via GitHub)" <gi...@apache.org>.
paultanay commented on issue #13656:
URL: https://github.com/apache/skywalking/issues/13656#issuecomment-4031217142
Started implementation as per the plan. I will share the update when it's ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature] [BanyanDB] Support ID generation during writing in measure module [skywalking]
Posted by "Nimesh-0000 (via GitHub)" <gi...@apache.org>.
Nimesh-0000 commented on issue #13656:
URL: https://github.com/apache/skywalking/issues/13656#issuecomment-3719832431
Hey Should I resolve this issue and yup it does required by reviewers with write access to do the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org