[royale-compiler] branch develop updated: Fix 'show-binding-warnings' was not working when set to false.

[gr...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

gregdove pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git


The following commit(s) were added to refs/heads/develop by this push:
     new 5e7d61a  Fix 'show-binding-warnings' was not working when set to false.
5e7d61a is described below

commit 5e7d61af720c9efec04162b4199cf66bd7e18126
Author: greg-dove <gr...@gmail.com>
AuthorDate: Sat Mar 28 20:59:08 2020 +1300

    Fix 'show-binding-warnings' was not working when set to false.
---
 .../clients/problems/ProblemSettingsFilter.java    | 23 +++-------------------
 .../MXMLDatabindingSourceNotBindableProblem.java   |  0
 2 files changed, 3 insertions(+), 20 deletions(-)

diff --git a/compiler-common/src/main/java/org/apache/royale/compiler/clients/problems/ProblemSettingsFilter.java b/compiler-common/src/main/java/org/apache/royale/compiler/clients/problems/ProblemSettingsFilter.java
index 2930c7f..57f7fb8 100644
--- a/compiler-common/src/main/java/org/apache/royale/compiler/clients/problems/ProblemSettingsFilter.java
+++ b/compiler-common/src/main/java/org/apache/royale/compiler/clients/problems/ProblemSettingsFilter.java
@@ -24,25 +24,7 @@ import java.util.Set;
 
 import org.apache.royale.compiler.config.ICompilerProblemSettings;
 import org.apache.royale.compiler.internal.config.ICompilerSettings;
-import org.apache.royale.compiler.problems.AbstractDeprecatedAPIProblem;
-import org.apache.royale.compiler.problems.ArrayCastProblem;
-import org.apache.royale.compiler.problems.AssignmentInConditionalProblem;
-import org.apache.royale.compiler.problems.ConstNotInitializedProblem;
-import org.apache.royale.compiler.problems.DateCastProblem;
-import org.apache.royale.compiler.problems.DeprecatedConfigurationOptionProblem;
-import org.apache.royale.compiler.problems.DuplicateQNameInSourcePathProblem;
-import org.apache.royale.compiler.problems.DuplicateVariableDefinitionProblem;
-import org.apache.royale.compiler.problems.ICompilerProblem;
-import org.apache.royale.compiler.problems.IllogicalComparionWithNaNProblem;
-import org.apache.royale.compiler.problems.IllogicalComparisonWithUndefinedProblem;
-import org.apache.royale.compiler.problems.InstanceOfProblem;
-import org.apache.royale.compiler.problems.NullUsedWhereOtherExpectedProblem;
-import org.apache.royale.compiler.problems.OverlappingSourcePathProblem;
-import org.apache.royale.compiler.problems.ScopedToDefaultNamespaceProblem;
-import org.apache.royale.compiler.problems.SemanticWarningProblem;
-import org.apache.royale.compiler.problems.StrictSemanticsProblem;
-import org.apache.royale.compiler.problems.ThisUsedInClosureProblem;
-import org.apache.royale.compiler.problems.VariableHasNoTypeDeclarationProblem;
+import org.apache.royale.compiler.problems.*;
 
 /**
  * A problem filter that implements filtering based the values of the following
@@ -154,7 +136,8 @@ public class ProblemSettingsFilter implements IProblemFilter
     {
         // TODO: call setShowProblemByClass() with problems relating to 
         // binding warnings.
-        // CMP-1424   
+        // CMP-1424
+        setShowProblemByClass(MXMLDatabindingSourceNotBindableProblem.class, showBindingWarnings);
     }
 
     private void setShowMultipleDefinitionWarnings(boolean b)
diff --git a/compiler/src/main/java/org/apache/royale/compiler/problems/MXMLDatabindingSourceNotBindableProblem.java b/compiler-common/src/main/java/org/apache/royale/compiler/problems/MXMLDatabindingSourceNotBindableProblem.java
similarity index 100%
rename from compiler/src/main/java/org/apache/royale/compiler/problems/MXMLDatabindingSourceNotBindableProblem.java
rename to compiler-common/src/main/java/org/apache/royale/compiler/problems/MXMLDatabindingSourceNotBindableProblem.java