You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/02 23:44:49 UTC

[GitHub] [spark] shaneknapp commented on a change in pull request #24266: [SPARK-25079][python] update python3 executable to 3.6.x

shaneknapp commented on a change in pull request #24266: [SPARK-25079][python] update python3 executable to 3.6.x
URL: https://github.com/apache/spark/pull/24266#discussion_r271535806
 
 

 ##########
 File path: dev/run-tests.py
 ##########
 @@ -546,7 +546,8 @@ def main():
         hadoop_version = os.environ.get("AMPLAB_JENKINS_BUILD_PROFILE", "hadoop2.7")
         test_env = "amplab_jenkins"
         # add path for Python3 in Jenkins if we're calling from a Jenkins machine
-        os.environ["PATH"] = "/home/anaconda/envs/py3k/bin:" + os.environ.get("PATH")
+        # TODO(sknapp):  s/py36/py3k before merging!
 
 Review comment:
   yeah...  this is so i can test against the py36 conda environment on the jenkins workers.  right before i merge, i'll pause jenkins, update the conda env name, push my revert and then let jenkins build again.
   
   folks will need to update their PRs post-merge as well.
   
   i'm waiting on @BryanCutler and the arrow 0.12.1 release before doing any of this, however.  probably early to mid next week.
   
   there will be a detailed email going out to dev@ about this on monday.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org