You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/21 16:27:55 UTC
[GitHub] [cloudstack] nvazquez opened a new pull request, #6297: Fix upload volume format
nvazquez opened a new pull request, #6297:
URL: https://github.com/apache/cloudstack/pull/6297
### Description
This PR fixes an issue if format is not properly passed in uppercase.
Note: this issue is applicable only to API when format value is lowercase, UI passes the format in uppercase to the uploadVolume API
````
2022-04-21 19:48:57,569 ERROR [c.c.a.ApiAsyncJobDispatcher] (API-Job-Executor-23:ctx-319bdf84 job-425147) (logid:864904bb) Unexpected exception while executing org.apache.cloudstack.api.command.admin.volume.UploadVolumeCmdByAdmin
java.lang.IllegalArgumentException: No enum constant com.cloud.storage.Storage.ImageFormat.ova
at java.base/java.lang.Enum.valueOf(Enum.java:240)
at com.cloud.storage.Storage$ImageFormat.valueOf(Storage.java:25)
at com.cloud.storage.VolumeApiServiceImpl$2.doInTransaction(VolumeApiServiceImpl.java:559)
at com.cloud.storage.VolumeApiServiceImpl$2.doInTransaction(VolumeApiServiceImpl.java:523)
at com.cloud.utils.db.Transaction.execute(Transaction.java:40)
at com.cloud.storage.VolumeApiServiceImpl.persistVolume(VolumeApiServiceImpl.java:523)
at com.cloud.storage.VolumeApiServiceImpl.uploadVolume(VolumeApiServiceImpl.java:345)
at com.cloud.storage.VolumeApiServiceImpl.uploadVolume(VolumeApiServiceImpl.java:203)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
````
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez closed pull request #6297: Fix upload volume format
Posted by GitBox <gi...@apache.org>.
nvazquez closed pull request #6297: Fix upload volume format
URL: https://github.com/apache/cloudstack/pull/6297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6297: Fix upload volume format
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6297:
URL: https://github.com/apache/cloudstack/pull/6297#issuecomment-1105490919
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6297: Fix upload volume format
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6297:
URL: https://github.com/apache/cloudstack/pull/6297#issuecomment-1105443990
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6297: Fix upload volume format
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6297:
URL: https://github.com/apache/cloudstack/pull/6297#issuecomment-1106810876
<b>Trillian test result (tid-3993)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31285 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6297-t3993-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6297: Fix upload volume format
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6297:
URL: https://github.com/apache/cloudstack/pull/6297#issuecomment-1105491738
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6297: Fix upload volume format
Posted by GitBox <gi...@apache.org>.
nvazquez merged PR #6297:
URL: https://github.com/apache/cloudstack/pull/6297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6297: Fix upload volume format
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6297:
URL: https://github.com/apache/cloudstack/pull/6297#issuecomment-1105444786
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6297: Fix upload volume format
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6297:
URL: https://github.com/apache/cloudstack/pull/6297#issuecomment-1106367280
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6297: Fix upload volume format
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6297:
URL: https://github.com/apache/cloudstack/pull/6297#issuecomment-1105476442
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6297: Fix upload volume format
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6297:
URL: https://github.com/apache/cloudstack/pull/6297#issuecomment-1106366456
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez closed pull request #6297: Fix upload volume format
Posted by GitBox <gi...@apache.org>.
nvazquez closed pull request #6297: Fix upload volume format
URL: https://github.com/apache/cloudstack/pull/6297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org