You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/24 10:30:19 UTC

[GitHub] [kafka] showuon commented on a change in pull request #10923: KAFKA-12976: Remove UNSUPPORTED_VERSION error from delete and describe topics calls

showuon commented on a change in pull request #10923:
URL: https://github.com/apache/kafka/pull/10923#discussion_r657826290



##########
File path: core/src/test/scala/unit/kafka/server/TopicIdWithOldInterBrokerProtocolTest.scala
##########
@@ -94,7 +94,8 @@ class TopicIdWithOldInterBrokerProtocolTest extends BaseRequestTest {
         )).setTimeoutMs(timeout)).build()
     val response = sendDeleteTopicsRequest(request)
     val error = response.errorCounts.asScala
-    assertEquals(2, error(Errors.UNSUPPORTED_VERSION))
+    // Previous versions of the code returned UNSUPPORTED_VERSION

Review comment:
       I think we can remove this comment because `Previous versions of the code` is a little ambiguous.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org