You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/16 15:35:38 UTC

[GitHub] [nuttx] acassis commented on a diff in pull request #8140: mm: Enable a dedicated kernel heap on `BUILD_FLAT` via `MM_KERNEL_HEAP`

acassis commented on code in PR #8140:
URL: https://github.com/apache/nuttx/pull/8140#discussion_r1071372041


##########
include/nuttx/mm/mm.h:
##########
@@ -88,9 +88,11 @@
 
 /* The kernel heap is never accessible from user code */
 
+#if defined(CONFIG_BUILD_KERNEL) || defined(CONFIG_BUILD_PROTECTED)
 #ifndef __KERNEL__

Review Comment:
   Gustavo, maybe it could be a good idea to put that comment:
   
   CONFIG_MM_KERNEL_HEAP must be undefined only when building the Userspace image, which only exists under CONFIG_BUILD_KERNEL and CONFIG_BUILD_PROTECTED. So we need to ensure !defined(__KERNEL__)
   
    just before the #if testing to let people understand easily the intention



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org