[GitHub] [spark] MaxGekk commented on a change in pull request #30934: [SPARK-33916][CORE] Fix fallback storage offset and improve compression codec test coverage

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #30934:
URL: https://github.com/apache/spark/pull/30934#discussion_r548998380



##########
File path: core/src/test/scala/org/apache/spark/storage/FallbackStorageSuite.scala
##########
@@ -227,43 +228,45 @@ class FallbackStorageSuite extends SparkFunSuite with LocalSparkContext {
     }
   }
 
-  test("Newly added executors should access old data from remote storage") {
-    sc = new SparkContext(getSparkConf(2, 0))
-    withSpark(sc) { sc =>
-      TestUtils.waitUntilExecutorsUp(sc, 2, 60000)
-      val rdd1 = sc.parallelize(1 to 10, 2)
-      val rdd2 = rdd1.map(x => (x % 2, 1))
-      val rdd3 = rdd2.reduceByKey(_ + _)
-      assert(rdd3.collect() === Array((0, 5), (1, 5)))
+  Seq("lz4", "snappy", "zstd").foreach { codec =>

Review comment:
       The doc of `IO_COMPRESSION_CODEC` says that it supports `lz4, lzf, snappy, and zstd`. Should we test `lzf` too?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org